Skip to content

Commit

Permalink
Use x icon for closing ide panel in sidepanel mode (#189)
Browse files Browse the repository at this point in the history
Button for closing IDE panel in sidepanel mode would consist of text
"Close IDE Panel" – this has been added for consistency with "Open IDE
Panel" button that we show when IDE isn't open. However, following the
same pattern here doesn't seem correct, as unlike for opening the IDE we
wouldn't be able to provide a single icon that'd make it clear what's
going to happen when you click it, it is also much easier to spot "Open
IDE Panel" text from a gazzilion of different icons that shows up in the
activity bar. To the contrary, the "x" icon has pretty clear semantics,
and it is easy for the user to understand what it does especially that
it is a sole icon that's present in IDE side-panel's activity bar.
Therefore there is no need to pollute that activity bar with a long and
unnecessary text button.
  • Loading branch information
kmagiera committed May 1, 2024
1 parent 5278dc8 commit ae3f4a0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/vscode-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"command": "RNIDE.closePanel",
"title": "Close IDE Panel",
"category": "React Native IDE",
"icon": "$(close)",
"enablement": "RNIDE.extensionIsActive"
},
{
Expand Down

0 comments on commit ae3f4a0

Please sign in to comment.