Move from activity bar to secondary bar hint #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
filip131311
force-pushed
the
@Filip131311/MoveFromActivityBarToSecondaryBar
branch
from
090d981
to
e1cce0c
Compare
filip131311
force-pushed
the
@Filip131311/MoveFromActivityBarToSecondaryBar
branch
from
e1cce0c
to
8b0d4e0
Compare
filip131311
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to control the panel position.
As a part of this PR we add a new position option "secondary side panel". We believe it may be useful to use secondary side panel for the IDE, but it isn't a popular feature of vscode and users are not familiar with it. On top of that, it cannot be fully controlled programatically. Specifically, there is no API to move panel from primary to secondary side panel. To workaround this issue, when user select "secondary side panel" option we ask them to move to secondary panel by hand using drag and drop.
This PR also updates the logic for command palette commands and makes it so that "Open IDE" is always visible unless the panel is opened.
We also do some renamings: Tabpanel -> TabPanel and Sidepanel -> SidePanel