Fix handling of numeric script ID when debug breakpoint is hit #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue introduced in fc3f800 where numeric script IDs were expected to be numbers. This is not inline with CDP spec, as the IDs are always strings. As a result we were attempting to parse those numeric IDs as URLs which resulted in an exception being thrown and debugger getting stuck without visual indicator.
In this PR I'm also addressing issue with touch events getting triggered when debug overlay is present. This resulted in touches being sent to device when someone would click the resume button. As a consequence when button was placed over an item with click event and breakpoint set, we'd be stuck in a breakpoint loop.