Add device localization on ios

packages/vscode-extension/package.json

@@ -381,6 +381,7 @@
     "@radix-ui/react-dropdown-menu": "^2.0.6",
     "@radix-ui/react-progress": "^1.0.3",
     "@radix-ui/react-radio-group": "^1.1.3",
+    "@radix-ui/react-scroll-area": "^1.1.0",
     "@radix-ui/react-select": "^2.0.0",
     "@radix-ui/react-slider": "^1.1.2",
     "@radix-ui/react-switch": "^1.0.3",

packages/vscode-extension/src/common/Project.ts

@@ -1,5 +1,7 @@
 import { DeviceInfo } from "./DeviceManager";
 
+export type Locale = string;
+
 export type DeviceSettings = {
   appearance: "light" | "dark";
   contentSize: "xsmall" | "small" | "normal" | "large" | "xlarge" | "xxlarge" | "xxxlarge";
@@ -9,6 +11,7 @@
     isDisabled: boolean;
   };
   hasEnrolledBiometrics: boolean;
+  locale: Locale;
 };
 
 export type ProjectState = {
@@ -34,7 +37,7 @@
 
 // important: order of values in this enum matters
 export enum StartupMessage {
   InitializingDevice = "Initializing device",
   StartingPackager = "Starting packager",
   BootingDevice = "Booting device",
   Building = "Building",

packages/vscode-extension/src/devices/AndroidEmulatorDevice.ts

@@ -117,9 +117,10 @@ export class AndroidEmulatorDevice extends DeviceBase {
         settings.location.latitude.toString(),
       ]);
     }
+    return false;
   }
 
-  async bootDevice() {
+  async bootDevice(settings: DeviceSettings) {
     // this prevents booting device with the same AVD twice
     await ensureOldEmulatorProcessExited(this.avdId);
 
@@ -162,6 +163,8 @@ export class AndroidEmulatorDevice extends DeviceBase {
     });
 
     this.serial = await initPromise;
+
+    await this.changeSettings(settings);
   }
 
   async openDevMenu() {

packages/vscode-extension/src/devices/DeviceBase.ts

@@ -1,7 +1,7 @@
 import { Disposable } from "vscode";
 import { Preview } from "./preview";
 import { BuildResult } from "../builders/BuildManager";
-import { AppPermissionType, DeviceSettings, TouchPoint } from "../common/Project";
+import { AppPermissionType, DeviceSettings, TouchPoint, Locale } from "../common/Project";
 import { DeviceInfo, DevicePlatform } from "../common/DeviceManager";
 import { tryAcquiringLock } from "../utilities/common";
 
@@ -14,8 +14,8 @@ export abstract class DeviceBase implements Disposable {
 
   abstract get lockFilePath(): string;
 
-  abstract bootDevice(): Promise<void>;
-  abstract changeSettings(settings: DeviceSettings): Promise<void>;
+  abstract bootDevice(deviceSettings: DeviceSettings): Promise<void>;
+  abstract changeSettings(settings: DeviceSettings): Promise<boolean>;
   abstract sendBiometricAuthorization(isMatch: boolean): Promise<void>;
   abstract installApp(build: BuildResult, forceReinstall: boolean): Promise<void>;
   abstract launchApp(build: BuildResult, metroPort: number, devtoolsPort: number): Promise<void>;

packages/vscode-extension/src/devices/IosSimulatorDevice.ts

@@ -8,7 +8,7 @@ import { IOSDeviceInfo, IOSRuntimeInfo, DevicePlatform, DeviceInfo } from "../co
 import { BuildResult } from "../builders/BuildManager";
 import path from "path";
 import fs from "fs";
-import { AppPermissionType, DeviceSettings } from "../common/Project";
+import { AppPermissionType, DeviceSettings, Locale } from "../common/Project";
 import { EXPO_GO_BUNDLE_ID, fetchExpoLaunchDeeplink } from "../builders/expoGo";
 import { ExecaError } from "execa";
 import { IOSBuildResult } from "../builders/buildIOS";
@@ -70,8 +70,13 @@ export class IosSimulatorDevice extends DeviceBase {
     return exec("xcrun", ["simctl", "--set", getOrCreateDeviceSet(), "shutdown", this.deviceUDID]);
   }
 
-  async bootDevice() {
+  async bootDevice(settings: DeviceSettings) {
     const deviceSetLocation = getOrCreateDeviceSet();
+
+    if (await this.shouldUpdateLocale(settings.locale)) {
+      await this.changeLocale(settings.locale);
+    }
+
     try {
       await exec("xcrun", ["simctl", "--set", deviceSetLocation, "boot", this.deviceUDID], {
         allowNonZeroExit: true,
@@ -84,10 +89,39 @@ export class IosSimulatorDevice extends DeviceBase {
         throw e;
       }
     }
+
+    await this.changeSettings(settings);
+  }
+
+  private async shouldUpdateLocale(locale: Locale): Promise<boolean> {
+    const deviceSetLocation = getOrCreateDeviceSet();
+    const deviceLocale = await exec("/usr/libexec/PlistBuddy", [
+      "-c",
+      `print :AppleLocale`,
+      path.join(
+        deviceSetLocation,
+        this.deviceUDID,
+        "data",
+        "Library",
+        "Preferences",
+        ".GlobalPreferences.plist"
+      ),
+    ]);
+    if (deviceLocale.stdout === locale) {
+      return false;
+    }
+    return true;
   }
 
-  async changeSettings(settings: DeviceSettings) {
+  async changeSettings(settings: DeviceSettings, ignoreChecks?: boolean): Promise<boolean> {
+    let shouldRestart = false;
     const deviceSetLocation = getOrCreateDeviceSet();
+
+    if (await this.shouldUpdateLocale(settings.locale)) {
+      shouldRestart = true;
+      this.changeLocale(settings.locale);
+    }
+
     await exec("xcrun", [
       "simctl",
       "--set",
@@ -147,7 +181,10 @@ export class IosSimulatorDevice extends DeviceBase {
       "-p",
       "com.apple.BiometricKit.enrollmentChanged",
     ]);
+
+    return shouldRestart;
   }
+
   async sendBiometricAuthorization(isMatch: boolean) {
     const deviceSetLocation = getOrCreateDeviceSet();
     await exec("xcrun", [
@@ -164,6 +201,26 @@ export class IosSimulatorDevice extends DeviceBase {
     ]);
   }
 
+  private async changeLocale(newLocale: Locale): Promise<boolean> {
+    const deviceSetLocation = getOrCreateDeviceSet();
+    const languageCode = newLocale.match(/([^_-]*)/)![1];
+    await exec("/usr/libexec/PlistBuddy", [
+      "-c",
+      `set :AppleLanguages:0 ${languageCode}`,
+      "-c",
+      `set :AppleLocale ${newLocale}`,
+      path.join(
+        deviceSetLocation,
+        this.deviceUDID,
+        "data",
+        "Library",
+        "Preferences",
+        ".GlobalPreferences.plist"
+      ),
+    ]);
+    return true;
+  }
+
   async configureMetroPort(bundleID: string, metroPort: number) {
     const deviceSetLocation = getOrCreateDeviceSet();
     const { stdout: appDataLocation } = await exec("xcrun", [

packages/vscode-extension/src/project/deviceSession.ts

@@ -10,6 +10,7 @@ import {
   ReloadAction,
   StartupMessage,
   TouchPoint,
+  Locale,
 } from "../common/Project";
 import { DevicePlatform } from "../common/DeviceManager";
 import { AndroidEmulatorDevice } from "../devices/AndroidEmulatorDevice";
@@ -121,8 +122,7 @@ export class DeviceSession implements Disposable {
 
   private async bootDevice(deviceSettings: DeviceSettings) {
     this.eventDelegate.onStateChange(StartupMessage.BootingDevice);
-    await this.device.bootDevice();
-    await this.device.changeSettings(deviceSettings);
+    await this.device.bootDevice(deviceSettings);
   }
 
   private async buildApp({ clean }: { clean: boolean }) {
@@ -241,8 +241,8 @@ export class DeviceSession implements Disposable {
     this.devtools.send("RNIDE_editorFileChanged", { filename, followEnabled });
   }
 
-  public async changeDeviceSettings(settings: DeviceSettings) {
-    await this.device.changeSettings(settings);
+  public async changeDeviceSettings(settings: DeviceSettings): Promise<boolean> {
+    return this.device.changeSettings(settings);
   }
 
   public focusBuildOutput() {