Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for new simserver CLI, update simserver submodule #561

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

balins
Copy link
Contributor

@balins balins commented Sep 18, 2024

This PR changes the commands that are sent to simserver to comply with new format.

@balins balins self-assigned this Sep 18, 2024
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 10:21am

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to udpate sim-server submodule to the revision that includes the changes. Otherwise it'll use the old version with incompatible commands

@balins
Copy link
Contributor Author

balins commented Sep 19, 2024

Updated the submodule to the latest version including running Android emulator without Xcode on macOS and separated stderr and stdout output.

@balins balins changed the title Adjust for new simserver CLI Adjust for new simserver CLI, update simserver submodule Sep 19, 2024
@balins balins merged commit 08ddf03 into main Sep 19, 2024
3 checks passed
@balins balins deleted the jb/adjust-for-new-simserver-cli branch September 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants