Migrate cashes directories #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
approved these changes
Sep 19, 2024
| const devices = fs.readdirSync(oldDeviceSetLocation); | ||
| if (devices.includes(deviceUDID)) { | ||
| return oldDeviceSetLocation; | ||
| } | ||
| return path.join(appCachesDir, "Devices", "iOS"); |
There was a problem hiding this comment.
should we return deviceSetLocation here as well?
| const pidFile = path.join(deviceSetLocation, this.deviceUDID, "lock.pid"); | ||
| return pidFile; | ||
| } | ||
|
|
||
| public dispose() { | ||
| public async dispose() { |
There was a problem hiding this comment.
why this change here? we don't call await in this method
filip131311
added a commit
that referenced
this pull request
Sep 23, 2024
This PR fixes a bug introduced by #562 witch always searched for localization settings in new caches directories for ios devices. Co-authored-by: Filip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the location of caches directory for all new devices, old devices remain in old cache location and can still be used and removed by the user by the user.