Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all commands to use message proxies #575

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

kmagiera
Copy link
Member

A while ago we introduced a new messaging mechanism that uses TypeScript interface and JS proxies to provide a RPC-like experience. We still had some leftover commands in the codebase, some of which were triggering some abandoned and unused code sections. This PR migrates the remaining commands to use the new RPC mechanism and cleans up dead code some of the unused commands were accessing.

  1. We are migrating error message and open URL commands to Utils interface
  2. We are updating relevant parts of the webview UI code to use Utils interface instead of calling into vscode API directly
  3. We are deleting "file follow" commands and related code that was only updating some internal variables that we never used.

Test plan

  1. Open project with IDE
  2. Click "report issue command" (which uses open URL)

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:15pm

@kmagiera kmagiera merged commit e40078e into main Sep 29, 2024
3 checks passed
@kmagiera kmagiera deleted the kmagiera/cleanup-webview-messaging branch September 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants