Fix Eas builds on Android #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
reviewed
Nov 13, 2024
| @@ -64,6 +64,13 @@ async function fetchBuild(config: EasConfig, platform: DevicePlatform) { | |||
|
|
|||
| const build = maxBy(builds, "completedAt")!; | |||
|
|
|||
| if (!build.binaryUrl.endsWith(".apk") && !build.binaryUrl.endsWith(".apex")) { | |||
| Logger.error( | |||
| `EAS build artefact needs to be in .apk or .apex format to work with the Radon IDE, make sure you set up eas to use "development" profile` | |||
There was a problem hiding this comment.
Suggested change
| `EAS build artefact needs to be in .apk or .apex format to work with the Radon IDE, make sure you set up eas to use "development" profile` | |
| `EAS build artifact needs to be a development build in .apk or .apex format to work with the Radon IDE, make sure you set up eas to use "development" profile` |
| const binaryPath = path.join(tmpDirectory, id); | ||
| const binaryPath = | ||
| platform === DevicePlatform.Android | ||
| ? path.join(tmpDirectory, `${id}.apk`) |
There was a problem hiding this comment.
The error message from above says it can be in apex format too?
Comment on lines
+33
to
+34
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| return; | |
| } | |
| } else { | |
| project.focusBuildOutput(); | |
| } |
Comment on lines
+80
to
+82
| const isEasBuild = | ||
| (!!eas?.android && projectState.selectedDevice?.platform === DevicePlatform.Android) || | ||
| (!!eas?.ios && projectState.selectedDevice?.platform === DevicePlatform.IOS); |
There was a problem hiding this comment.
wouldn't it be easier to pass information whether its eas or not via project? It seems like we have those checks already to tell which build to start, so duplicating it here would just increase the coupling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional user facing information about eas builds, to let users know when production build is used instead of development one. More over eas build crashes are getting a new build error alert description to redirect users to Radon IDE log instead of non existing build logs.
Finally this PR adds .apk file extension to android packages to avoid errors with tools we use to install and uninstall application on device.
Fixes android portion of #678
How Has This Been Tested:
Run an application using eas on android using production and development profiles.