fix(Android): recalculating layout after changing html styles #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@IvanIhnatsiuk thanks for this, as this PR can have some impact on apps which are already using library, I would like to discuss this a little bit more. It would be super cool if you can catch up with me on discord (username |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we change the HTML styles on Android, they will not be applied in any way until we first enter any styles. We also got a bug with the initial defaultValue, because everything started to depend on who was the first to be counted (it depends on who was the first to be passed from JS to the component).
Thus, I added the calculation of the lead when changing the HTML style on Android.
Videos
Before:
Screen.Recording.2025-11-07.at.19.24.38.mov
Screen.Recording.2025-11-07.at.19.16.29.mov
After:
Screen.Recording.2025-11-07.at.19.25.20.mov