Skip to content

feat: added system and bundleId to telemetry to version 0.8 - #1312

Merged
msluszniak merged 4 commits into
release/0.8from
@mkopcins/telemetry_update_08
Jul 28, 2026
Merged

feat: added system and bundleId to telemetry to version 0.8#1312
msluszniak merged 4 commits into
release/0.8from
@mkopcins/telemetry_update_08

Conversation

@mkopcins

@mkopcins mkopcins commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Added two new fields to model downloads telemetry: system and bundleId.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run any new model (to trigger a download event) and check if new event with that bundle id is registered on the website https://ai.swmansion.com/telemetry/admin/downloads

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@mkopcins
mkopcins requested a review from msluszniak July 16, 2026 12:44
@msluszniak msluszniak added the feature PRs that implement a new feature label Jul 16, 2026
@msluszniak msluszniak linked an issue Jul 16, 2026 that may be closed by this pull request
Add system and bundleId to model downloads telemetry #1313
Closed
msluszniak
msluszniak reviewed Jul 17, 2026
View reviewed changes
Comment thread apps/llm/package.json
"react": "19.1.0",
"react-native": "0.81.5",
"react-native-audio-api": "^0.8.2",
"react-native-audio-api": "^0.12.2",

@msluszniak msluszniak Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need changes to demo app in release* branch?

@mkopcins mkopcins Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had troubles testing it with demo app without those changes

msluszniak
msluszniak reviewed Jul 21, 2026
View reviewed changes

@msluszniak msluszniak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no PrivacyInfo.xcprivacy in the package. Sending bundle id + derived country off-device is the kind of collection Apple's privacy-manifest rules cover — pre-existing gap, but this PR makes it more relevant. Same for docs: telemetry has no prose page and no opt-out, and bundleId identifies the app shipping RNE.

Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
@msluszniak

msluszniak commented Jul 22, 2026

Copy link
Copy Markdown
Member

ios/PrivacyInfo.xcprivacy doesn't exist in the package, the commit adds the resource_bundles reference but not the file itself. The PrivacyInfo.xcprivacy file needs to be committed here, with the actual NSPrivacyCollectedDataTypes entries for the data being sent. Also add ios/PrivacyInfo.xcprivacy to the files array in package.json so it's included in the npm tarball.

@msluszniak

msluszniak commented Jul 28, 2026

Copy link
Copy Markdown
Member

Ok, I'm merging this one and now I'll test the 0.9 version of patch. Then will proceed with both patches to v0.8 and v0.9.

@msluszniak
msluszniak merged commit ff22f17 into release/0.8 Jul 28, 2026
2 of 3 checks passed
@msluszniak
msluszniak deleted the @mkopcins/telemetry_update_08 branch July 28, 2026 09:47
@msluszniak msluszniak mentioned this pull request Jul 28, 2026
Merged
7 tasks
msluszniak added a commit that referenced this pull request Aug 3, 2026
@msluszniak
chore: Release v0.8.5 (#1334)
6e1cb0a 
## Description

Patch release **v0.8.5**. The bundleId/system telemetry change (#1312)
is already merged into `release/0.8`; this PR only bumps the core
package version.

- Bump `packages/react-native-executorch/package.json` to `0.8.5`.
- Adapter packages (`bare-resource-fetcher`, `expo-resource-fetcher`)
untouched — versions not bumped.

### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [x] Other (chores, tests, code style improvements etc.)

### Tested on

- [ ] iOS
- [ ] Android

### Related issues

#1312

### Checklist

- [x] I have performed a self-review of my code
- [x] My changes generate no new warnings
@msluszniak msluszniak mentioned this pull request Aug 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msluszniak msluszniak msluszniak approved these changes

Assignees

@mkopcins mkopcins

Labels

feature PRs that implement a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add system and bundleId to model downloads telemetry

2 participants

@mkopcins @msluszniak