Skip to content

[RNE Rewrite] chore!: remove resource fetcher directories and references - #1356

Open
barhanc wants to merge 1 commit into
rne-rewritefrom
remove-resource-fetchers
Open

[RNE Rewrite] chore!: remove resource fetcher directories and references#1356
barhanc wants to merge 1 commit into
rne-rewritefrom
remove-resource-fetchers

Conversation

@barhanc

@barhanc barhanc commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

  1. Deleted Packages & Workflows:
    • packages/bare-resource-fetcher/
    • packages/expo-resource-fetcher/
    • .github/workflows/npm-publish-bare-resource-fetcher.yml
    • .github/workflows/npm-publish-expo-resource-fetcher.yml
  2. Updated Build & Config Files:
    • package.json: Removed resource-fetcher package exclusions from scripts.
    • ci.yml: Removed exclusions from CI steps.
    • App tsconfigs (tsconfig.json, tsconfig.json): Removed path aliases for react-native-
    executorch-expo-resource-fetcher.
  3. Untouched / Reverted Files:
    • RELEASE.md (reverted)
    • README.md & readmes/ (reverted)
    • scripts/errors.config.ts (reverted)
    • docs/ (ignored)

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

N/A

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@barhanc barhanc changed the title [RNE Rewrite] refactor!: remove resource fetcher packages and references [RNE Rewrite] refactor!: remove resource fetcher directories and references Aug 7, 2026
@barhanc barhanc self-assigned this Aug 7, 2026
@barhanc

barhanc commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

Two questions regarding the additional packages:

  • what should we do with react-native-executorch-webrtc; I'm not at all familiar with its backstory and where it is used?
  • this PR deletes the workflows for publishing the resource-fetchers to npm, I'm not sure if that's correct?

@barhanc
barhanc marked this pull request as ready for review August 7, 2026 20:46
@msluszniak

Copy link
Copy Markdown
Member

react-native-executorch-webrtc is a package that was used in fishjam. Precisely, we needed to make a proxy package that would wire our library with fishjam to support selfie segmentation. To decide either we should support it or not, we should contact fishjam team.

Regarding removing flows for publishing, it's okay, since even if we want to publish patches for previous versions, we have them on 0.9, ... release branches.

@barhanc barhanc changed the title [RNE Rewrite] refactor!: remove resource fetcher directories and references [RNE Rewrite] chore!: remove resource fetcher directories and references Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants