Update RNGestureHandlerPackage to supported stable API #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Nov 20, 2024
android/package74/src/main/java/com/swmansion/gesturehandler/RNGestureHandlerPackage.kt
Outdated
Show resolved
Hide resolved
j-piasecki
approved these changes
Nov 20, 2024
tomekzaw
approved these changes
Nov 27, 2024
latekvo
approved these changes
Nov 28, 2024
j-piasecki
approved these changes
Nov 29, 2024
|
Just since I stumbled over it after releasing the same changes for my lib: react-native-community/cli#2563 @jakex7 Right now the fixed versions of the cli are not shipped yet with new RN packages, and old packages without updated cli are broken too.... |
|
Thanks for the info @RonRadtke! Fortunately RNGH should be safe as it falls into first check which is less strict and has been there for a long time FYI @j-piasecki |
This was referenced Jul 21, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated
TurboReactPackagewith the newerBaseReactPackageto improve compatibility with future React Native releases. Note that this change requires at least [email protected]+.Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541
Test plan
CI should pass