chore: Clean up getViewProp implementation #8056
Conversation
| // @ts-ignore this is fine | ||
| const viewTag = animatedRef() as number; | ||
| const result = await getViewProp(viewTag, 'opacity', animatedRef.current); | ||
| const result = await getViewProp(animatedRef.current, 'opacity'); |
There was a problem hiding this comment.
I know that this params order change is a breaking change but, since the viewTag was the first param, I had to move all params (and I took liberty of changing the order of params to get the component as the first param and the prop name as the second one).
There was a problem hiding this comment.
Why don't we just pass animatedRef instead of animatedRef.current?
There was a problem hiding this comment.
This is how it was working before - we were passing a component instance instead of a ref object. It will be also a bit harder to type this method properly if we wanted to pass a ref (it should accept React's ref, as well as, our animated ref)
There was a problem hiding this comment.
I talked with @tjzel and we decided to add method on the animated ref for easier usage. The old API will remain unchanged for backwards compatibility.
MatiPl01
force-pushed
the
@matipl01/remove-unused-getViewProp-param
branch
from
1973991 to
d5345d9
Compare
MatiPl01
force-pushed
the
@matipl01/remove-unused-getViewProp-param
branch
from
d5345d9 to
4632dfc
Compare
| // @ts-ignore this is fine | ||
| const viewTag = animatedRef() as number; | ||
| const result = await getViewProp(viewTag, 'opacity'); | ||
| const result = await animatedRef.getViewProp<number>('opacity'); |
There was a problem hiding this comment.
I'm not sure if we want getViewProp to be in the public API of Reanimated. This method is meant for runtime tests and should not be used by apps as far as I know.
There was a problem hiding this comment.
Mhm, it was exported as a function but not documented, so maybe you are right that this was meant only for the internal use. What should I do then if it is not a part of the public API? Can I restore previous changes that just removed the unused param from the function signature and not care about backwards compatibility?
There was a problem hiding this comment.
If it's not a part of the public API then we can import it from src/ directly in the runtime tests, instead of putting it in public exports.
There was a problem hiding this comment.
- Let's not care about backwards compatibility
- Let's convert it from ref method back to a standalone function
- I'm okay with moving it to
src/directory
Summary
This PR removes unused
viewTagprop from thegetViewPropfunction which is a leftover from the old Paper-compatible implementation.Test plan
I tested it on the
getViewPropexample (which for some reason was disabled before on Fabric, likely because of the invalidgetViewPropimplementation).Screen.Recording.2025-08-12.at.00.26.35.mp4