chore: Animated styles and props cleanup #8140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
commented
Aug 26, 2025
Comment on lines
+258
to
+272
| /** | ||
| * If the animated prop is an array, we need to directly set each | ||
| * property (manually spread it). This prevents issues where the color | ||
| * prop might be incorrectly linked with its `toValue` and `current` | ||
| * states, causing abrupt transitions or 'jumps' in animation states. | ||
| */ | ||
| if (Array.isArray(updates[propName])) { | ||
| updates[propName].forEach((obj) => { | ||
| for (const prop in obj) { | ||
| if (!last[propName] || typeof last[propName] !== 'object') { | ||
| last[propName] = {}; | ||
| } | ||
| last[propName][prop] = obj[prop]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
TODO: Fix this code, it is invalid as it assumes that array can only contain objects which is not true (e.g. see fontVariant prop which is an array of strings).
This implementation should be generalized for any structure, not just arrays of objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan