fix(iOS): scrollview & interactivePopContentGestureRecognizer interaction
#3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
added a commit
that referenced
this pull request
Nov 27, 2025
…re requirements (#3420) Fixes #3302 Supersedes #3304 ## Description This PR fixes the failure requirements for content pop gesture. The changes introduced in #3265 fixed the immediate dismissing of screen when scrolling on horizontal ScrollView, but at the same time introduced a regression for vertical scrolling. Here, we apply the failure requirement only if the ScrollView has horizontal scrolling. ## Changes Updated `RNSScreenStack`'s `gestureRecognizer:shouldRequireFailureOf:otherGestureRecognizer` to check if ScrollView has horizontal scrolling. ### After changes https://github.com/user-attachments/assets/de8bfdaa-aa9b-4c25-917e-2d631bc590df ## Testing Use `Test1072`. Make sure to check custom animations with `animation` and `animationMatchesGesture`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to fix #3302
Changes
Test code and steps to reproduce
Checklist