631 in custom tournament new match should be added last appended

[softwaremagico]

No description provided.

[sonarqubecloud]

Quality Gate passed for 'Kendo Tournament Manager Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dim-geo]

Hi, can you please elaborate what was implemented here?
matches are added in second place since after add the first match is selected...
How to select shiaijo to add?

[softwaremagico]

This feature was developed for correcting fights, or handle very specific cases. If you are an a pool of a tournament, you can remove an existing fight and add a corrected one. Note: this is not expected on an official tournament, but happens sometimes when I do a internal tournament on my club. We only use this feature for training, where we can focus on some kendokas an try different combinations, but it is not used very often.

Note that selecting a fight for adding a new one is desired on this situation, that is the reason why I have not accepted the first part of the issue, and I have focused only on the part of the shiaijo.

The new created fight, always copy the information from the currently selected fight. So, if you are in a pool with a shiaijo, the new fight will be added on this pool, with this shiaijo. The last thing was wrong, as all fights were always set to the first shiaijo.

But this feature is not for creating a tournament from the scratch, you need to use the editor for this purpose. So if no fights exists, always the new fights will be generated on the first shiaijo.

On your bug you are focusing on Custom Tournaments. That it is a little annoying that you must always select the position of the fight. But I want to keep the flexibility for other tournaments, as the feature for adding and removing is the same.
Any ideas how to handle both of them? Maybe I can handle different cases depending on the type of tournament selected. But maybe is to complex for a standard user.