Skip to content

Replace the Schedule used for repeats/retries with an interval-list based approach#317

Merged
adamw merged 7 commits into
masterfrom
improve-retries
May 30, 2025
Merged

Replace the Schedule used for repeats/retries with an interval-list based approach#317
adamw merged 7 commits into
masterfrom
improve-retries

Conversation

@adamw

@adamw adamw commented May 29, 2025

Copy link
Copy Markdown
Member

The new Schedule class allows for compositional definitions of schedules, and follows the design outlined by @miciek in https://www.youtube.com/watch?v=RWvTziDfFUQ.

@adamw

adamw commented May 29, 2025

Copy link
Copy Markdown
Member Author

@miciek if you'd have a spare minute, take a look at the Schedule class, maybe you'd have some comments/suggestions, as this tries to implement what you've talked about in your Scalar talk :)

@adamw adamw merged commit f35bbfb into master May 30, 2025
5 checks passed
@adamw adamw deleted the improve-retries branch May 30, 2025 06:25
@miciek

miciek commented Jun 6, 2025

Copy link
Copy Markdown

@miciek if you'd have a spare minute, take a look at the Schedule class, maybe you'd have some comments/suggestions, as this tries to implement what you've talked about in your Scalar talk :)

@adamw Thanks for doing this! It looks great :) I probably wouldn't do it your way, but it's much better. I love the flexibility. I will play around with this one, thanks again!

I haven't run it yet but just looking at the code, I can't figure out what would be the preferred way of doing custom Schedules using your own LazyList operators? That's definitely the first thing I am trying out when I sit down to play with this version :)

@adamw

adamw commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

I haven't run it yet but just looking at the code, I can't figure out what would be the preferred way of doing custom Schedules using your own LazyList operators? That's definitely the first thing I am trying out when I sit down to play with this version :)

I suppose it would just be Schedule(() => LazyList(1, 50, 2)), or maybe I don't understand the question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants