V10

.clang-format

@@ -5,6 +5,7 @@ AllowShortIfStatementsOnASingleLine: false
 ColumnLimit: 140
 ---
 Language: Cpp
+AccessModifierOffset: -1
 AlignConsecutiveMacros: None
 AlignConsecutiveAssignments: None
 BraceWrapping:

.clang-tidy

@@ -1,5 +1,23 @@
 Checks:
   - modernize-use-using
   - readability-avoid-const-params-in-decls
+  - misc-unused-parameters,
+  - readability-identifier-naming
 
-SystemHeaders: false
+# ^ Without unused-parameters the readability-identifier-naming check doesn't cause any warnings.
+
+CheckOptions:
+  - { key: readability-identifier-naming.ClassCase,                   value: PascalCase }
+  - { key: readability-identifier-naming.EnumCase,                    value: PascalCase }
+  - { key: readability-identifier-naming.FunctionCase,                value: camelCase }
+  - { key: readability-identifier-naming.GlobalVariableCase,          value: camelCase }
+  - { key: readability-identifier-naming.GlobalFunctionCase,          value: camelCase }
+  - { key: readability-identifier-naming.GlobalConstantCase,          value: SCREAMING_SNAKE_CASE }
+  - { key: readability-identifier-naming.MacroDefinitionCase,         value: SCREAMING_SNAKE_CASE }
+  - { key: readability-identifier-naming.ClassMemberCase,             value: camelCase }
+  - { key: readability-identifier-naming.PrivateMemberPrefix,         value: m_ }
+  - { key: readability-identifier-naming.ProtectedMemberPrefix,       value: m_ }
+  - { key: readability-identifier-naming.PrivateStaticMemberPrefix,   value: s_ }
+  - { key: readability-identifier-naming.ProtectedStaticMemberPrefix, value: s_ }
+  - { key: readability-identifier-naming.PublicStaticConstantCase,    value: SCREAMING_SNAKE_CASE }
+  - { key: readability-identifier-naming.EnumConstantCase,            value: PascalCase }

.editorconfig

@@ -3,6 +3,20 @@
 # top-most EditorConfig file
 root = true
 
+[*]
+indent_style = space
+indent_size = 4
+end_of_line = lf
+charset = utf-8
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.{yml,nix}]
+indent_size = 2
+
 # C++ Code Style settings
 [*.{c++,cc,cpp,cppm,cxx,h,h++,hh,hpp,hxx,inl,ipp,ixx,tlh,tli}]
 cpp_generate_documentation_comments = doxygen_slash_star
+
+[CMakeLists.txt]
+ij_continuation_indent_size = 4

.envrc

@@ -1,2 +1,2 @@
-use flake
+use nix
 watch_file nix/*.nix

.git-blame-ignore-revs

@@ -5,3 +5,9 @@ bbb3b3e6f6e3c0f95873f22e6d0a4aaf350f49d9
 
 # (nix) alejandra -> nixfmt
 4c81d8c53d09196426568c4a31a4e752ed05397a
+
+# reformat codebase
+1d468ac35ad88d8c77cc83f25e3704d9bd7df01b
+
+# format a part of codebase
+5c8481a118c8fefbfe901001d7828eaf6866eac4

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -2,64 +2,64 @@ name: Bug Report
 description: File a bug report
 labels: [bug]
 body:
-  - type: markdown
-    attributes:
-      value: |
-        If you need help with running Minecraft, please visit us on our Discord before making a bug report.
+- type: markdown
+  attributes:
+    value: |
+      If you need help with running Minecraft, please visit us on our Discord before making a bug report.
 
-        Before submitting a bug report, please make sure you have read this *entire* form, and that:
-        * You have read the [Prism Launcher wiki](https://prismlauncher.org/wiki/) and it has not answered your question.
-        * Your bug is not caused by Minecraft or any mods you have installed.
-        * Your issue has not been reported before, [make sure to use the search function!](https://github.com/PrismLauncher/PrismLauncher/issues)
+      Before submitting a bug report, please make sure you have read this *entire* form, and that:
+      * You have read the [Prism Launcher wiki](https://prismlauncher.org/wiki/) and it has not answered your question.
+      * Your bug is not caused by Minecraft or any mods you have installed.
+      * Your issue has not been reported before, [make sure to use the search function!](https://github.com/PrismLauncher/PrismLauncher/issues)
 
-        **Do not forget to give your issue a descriptive title.** "Bug in the instance screen" makes it hard to distinguish issues at a glance.
-  - type: dropdown
-    attributes:
-      label: Operating System
-      description: If you know this bug occurs on multiple operating systems, select all you have tested.
-      multiple: true
-      options:
-        - Windows
-        - macOS
-        - Linux
-        - Other
-  - type: textarea
-    attributes:
-      label: Version of NMC Launcher
-      description: The version of NMC Launcher used in the bug report.
-      placeholder: NMC Launcher 5.0
-    validations:
+      **Do not forget to give your issue a descriptive title.** "Bug in the instance screen" makes it hard to distinguish issues at a glance.
+- type: dropdown
+  attributes:
+    label: Operating System
+    description: If you know this bug occurs on multiple operating systems, select all you have tested.
+    multiple: true
+    options:
+    - Windows
+    - macOS
+    - Linux
+    - Other
+- type: textarea
+  attributes:
+    label: Version of Prism Launcher
+    description: The version of Prism Launcher used in the bug report.
+    placeholder: Prism Launcher 5.0
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Version of Qt
+    description: The version of Qt used in the bug report. You can find it in Help -> About Prism Launcher -> About Qt.
+    placeholder: Qt 6.3.0
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Description of bug
+    description: What did you expect to happen, what happened, and why is it incorrect?
+    placeholder: The cat button should show a cat, but it showed a dog instead!
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Steps to reproduce
+    description: A bulleted list, or an exported instance if relevant.
+    placeholder: "* Press the cat button"
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Suspected cause
+    description: If you know what could be causing this bug, describe it here.
+  validations:
+    required: false
+- type: checkboxes
+  attributes:
+    label: This issue is unique
+    options:
+    - label: I have searched the issue tracker and did not find an issue describing my bug.
       required: true
-  - type: textarea
-    attributes:
-      label: Version of Qt
-      description: The version of Qt used in the bug report. You can find it in Help -> About Prism Launcher -> About Qt.
-      placeholder: Qt 6.3.0
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Description of bug
-      description: What did you expect to happen, what happened, and why is it incorrect?
-      placeholder: The cat button should show a cat, but it showed a dog instead!
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Steps to reproduce
-      description: A bulleted list, or an exported instance if relevant.
-      placeholder: "* Press the cat button"
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Suspected cause
-      description: If you know what could be causing this bug, describe it here.
-    validations:
-      required: false
-  - type: checkboxes
-    attributes:
-      label: This issue is unique
-      options:
-        - label: I have searched the issue tracker and did not find an issue describing my bug.
-          required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -1 +1,5 @@
 blank_issues_enabled: true
+contact_links:
+  - name: Prism Launcher Matrix Support Room
+    url: https://matrix.to/#/#prism-support:matrix.org
+    about: Please ask for support here before opening an issue.

.github/ISSUE_TEMPLATE/rfc.yml

@@ -3,66 +3,66 @@ name: Request for Comment (RFC)
 description: Propose a larger change and start a discussion.
 labels: [rfc]
 body:
-  - type: markdown
-    attributes:
-      value: |
-        ### Use this form to suggest a larger change for NMC Launcher.
-  - type: textarea
-    attributes:
-      label: Goal
-      description: Short description, 1-2 sentences.
-      placeholder: Remove the cat from the launcher.
-    validations:
+- type: markdown
+  attributes:
+    value: |
+      ### Use this form to suggest a larger change for Prism Launcher.
+- type: textarea
+  attributes:
+    label: Goal
+    description: Short description, 1-2 sentences.
+    placeholder: Remove the cat from the launcher.
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Motivation
+    description: |
+      Introduce the topic. If this is a not-well-known section of Prism Launcher, a detailed explanation of the background is recommended.
+      Some example points of discussion:
+       - What specific problems are you facing right now that you're trying to address?
+       - Are there any previous discussions? Link to them and summarize them (don't force your readers to read them though!).
+       - Is there any precedent set by other software? If so, link to resources.
+    placeholder: I don't like cats. I think many users also don't like cats.
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Specification
+    description: A concrete, thorough explanation of what is being planned.
+    placeholder: Remove the cat button and all references to the cat from the codebase. Including resource files.
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Drawbacks
+    description: Carefully consider every possible objection and issue with your proposal. This section should be updated as feedback comes in from discussion.
+    placeholder: Some users might like cats.
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Unresolved Questions
+    description: |
+      Are there any portions of your proposal which need to be discussed with the community before the RFC can proceed?
+      Be careful here -- an RFC with a lot of remaining questions is likely to be stalled.
+      If your RFC is mostly unresolved questions and not too much substance, it may not be ready.
+    placeholder: Do a lot of users care about the cat?
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Alternatives Considered
+    description: A list of alternatives, that have been considered and offer equal or similar features to the proposed change.
+    placeholder: Maybe the cat could be replaced with an axolotl?
+  validations:
+    required: true
+- type: checkboxes
+  attributes:
+    label: This suggestion is unique
+    options:
+    - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.
       required: true
-  - type: textarea
-    attributes:
-      label: Motivation
-      description: |
-        Introduce the topic. If this is a not-well-known section of NMC Launcher, a detailed explanation of the background is recommended.
-        Some example points of discussion:
-         - What specific problems are you facing right now that you're trying to address?
-         - Are there any previous discussions? Link to them and summarize them (don't force your readers to read them though!).
-         - Is there any precedent set by other software? If so, link to resources.
-      placeholder: I don't like cats. I think many users also don't like cats.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Specification
-      description: A concrete, thorough explanation of what is being planned.
-      placeholder: Remove the cat button and all references to the cat from the codebase. Including resource files.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Drawbacks
-      description: Carefully consider every possible objection and issue with your proposal. This section should be updated as feedback comes in from discussion.
-      placeholder: Some users might like cats.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Unresolved Questions
-      description: |
-        Are there any portions of your proposal which need to be discussed with the community before the RFC can proceed? 
-        Be careful here -- an RFC with a lot of remaining questions is likely to be stalled. 
-        If your RFC is mostly unresolved questions and not too much substance, it may not be ready.
-      placeholder: Do a lot of users care about the cat?
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Alternatives Considered
-      description: A list of alternatives, that have been considered and offer equal or similar features to the proposed change.
-      placeholder: Maybe the cat could be replaced with an axolotl?
-    validations:
-      required: true
-  - type: checkboxes
-    attributes:
-      label: This suggestion is unique
-      options:
-        - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.
-          required: true
-  - type: textarea
-    attributes:
-      label: You may use the editor below to elaborate further.
+- type: textarea
+  attributes:
+    label: You may use the editor below to elaborate further.

.github/ISSUE_TEMPLATE/suggestion.yml

@@ -2,37 +2,37 @@ name: Suggestion
 description: Make a suggestion
 labels: [enhancement]
 body:
-  - type: markdown
-    attributes:
-      value: |
-        ### Use this form to suggest a feature for NMC Launcher.
-  - type: input
-    attributes:
-      label: Role
-      description: In what way do you use Prism Launcher that needs this feature?
-      placeholder: I play modded Minecraft.
-    validations:
+- type: markdown
+  attributes:
+    value: |
+      ### Use this form to suggest a feature for Prism Launcher.
+- type: input
+  attributes:
+    label: Role
+    description: In what way do you use Prism Launcher that needs this feature?
+    placeholder: I play modded Minecraft.
+  validations:
+    required: true
+- type: input
+  attributes:
+    label: Suggestion
+    description: What do you want Prism Launcher to do?
+    placeholder: I want the cat button to meow.
+  validations:
+    required: true
+- type: input
+  attributes:
+    label: Benefit
+    description: Why do you need Prism Launcher to do this?
+    placeholder: so that I can always hear a cat when I need to.
+  validations:
+    required: true
+- type: checkboxes
+  attributes:
+    label: This suggestion is unique
+    options:
+    - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.
       required: true
-  - type: input
-    attributes:
-      label: Suggestion
-      description: What do you want NMC Launcher to do?
-      placeholder: I want the cat button to meow.
-    validations:
-      required: true
-  - type: input
-    attributes:
-      label: Benefit
-      description: Why do you need NMC Launcher to do this?
-      placeholder: so that I can always hear a cat when I need to.
-    validations:
-      required: true
-  - type: checkboxes
-    attributes:
-      label: This suggestion is unique
-      options:
-        - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.
-          required: true
-  - type: textarea
-    attributes:
-      label: You may use the editor below to elaborate further.
+- type: textarea
+  attributes:
+    label: You may use the editor below to elaborate further.