Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cimpy 3_0 #40

Open
wants to merge 27 commits into
base: cgmes3
Choose a base branch
from
Open

Conversation

ThomasSchwierz
Copy link

Hey! We changed the cimpy 3 branch to add a fully functioning version of cimpy 3. Feel free to review it, we want this to become open source relatively quickly to be usable via python package index.

Regards

Thomas

stv0g and others added 27 commits June 17, 2024 15:41
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Okay, this PR got a bit larger than anticipated.
But there were just too many small things which I want to cleanup:

- General code-style:
  - Formatting via [black](https://github.com/psf/black)
- PEP-8 compliance via
[flake8](https://flake8.pycqa.org/en/3.1.1/index.html)
  - Fix a bunch of  code-smells detected by Sonar Cloud
- Improve code-quality
  - Remove `print()` and replace by `logging` module
- Replace `.format()`-style string formatting by printf-style for
logging module
- Revamp CI pipelines:
- I removed the in-repo CI action for building the documentation and
converted it to a normal workflow
    - This allowed removing a lot of stuff:
      - Dockerfile
      - docu.sh
      - action.yaml
      - entrypoint.sh
    - Removal of GitLab CI config
- The documentation is now also build in PR pipelines, but just not
deployed.
- Migrate to more modern Python packaging practices:
  - `setup.py` has been replace by `pyproject.toml`
- Check code-style, formatting and more with
[pre-commit](https://pre-commit.com/)
  - Will also be enforced by CI workflow
…pages (sogno-platform#32)

This is just a small follow-up PR for sogno-platform#30 

I forgot to set the proper permissions for the GitHub actions workflow
which deploys the documentation to GitHub pages.
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Markus Mirz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants