Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMU signal implementation using GSL #258

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

leonardocarreras
Copy link
Collaborator

This is the continuation of #152 started by @BeijiaYang, but the changes over time made it obsolete, and we are substituting it with this.

The goal is:

  1. To create a new class that provides a measurement-like output.
  2. To be able to control the parameters of the measurement signal.

This is still a draft WIP.

@leonardocarreras leonardocarreras added the enhancement New feature or request label Oct 24, 2023
@pipeacosta
Copy link
Collaborator

pipeacosta commented Oct 25, 2023

The PMU implementation requires to build with GSL. This is an option which does not come by default and we don't want to make it a default option. Therefore, we have two alternatives:

  • Include a new option in CMakeLists which triggers the GSL installation, something like WITH_PMU
  • Leave it as it is, and build with WITH_GSL for PMU support

Both options would require an extra action in the CI

@leonardocarreras leonardocarreras mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants