Implement RL node reduced equations #283
Conversation
Signed-off-by: Markus Mirz <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Kalyan <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Kalyan <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Kalyan <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: kalyan1370 <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: martin.moraga <[email protected]>
martinmoraga
force-pushed
the
rl-element-rebase
branch
from
298758d
to
13719e5
Compare
|
There was a problem hiding this comment.
Hi Martin,
Thank you for this nice enhancement. This is the proper way to model series RL branches! Also, really cool that you did implementation in all of the modeling domains and added a nice documentation.
I have added a few comments for your consideration, none of them are major.
There was a problem hiding this comment.
This would be great to also add EMT domain equations here for series RL element, as EMT model is included in this PR.
| Real preCurrFracImag = (-2. * b) / (1. + b * b); | ||
|
|
||
| Real preCurrFracReal = | ||
| (1. - std::pow(b, 2) + -std::pow(**mResistance * a, 2)) / |
There was a problem hiding this comment.
is a + - before std::pow(**mResistance * a, 2)) on purpose? Can it be just -?
| Real equivCondReal = a / (1. + b * b); | ||
| Real equivCondImag = -a * b / (1. + b * b); | ||
| Real equivCondReal = (a + **mResistance * std::pow(a, 2)) / | ||
| (std::pow(1. + **mResistance * a, 2) + std::pow(b, 2)); |
There was a problem hiding this comment.
denominator (std::pow(1. + **mResistance * a, 2) + std::pow(b, 2)) is calculated several times. Calculating this once and storing the result in a variable would make the code easier to read.
There was a problem hiding this comment.
ResIndSeries is quite a clear name, but does not sound too nice when you try to pronounce it aloud.
I've noticed in DPsim there are two common naming conventions for the component classes:
-
Either not abbreviating the component's name at all, like
EMT_Ph3_SeriesResistor. -
Or abbreviating the component's name by a single letter, like
EMT_Ph3_RXLoad.
Following these conventions, I'd propose DP_Ph1_SeriesRL, DP_Ph1_SeriesResistorInductor. Same goes also for EMT, SP and 3-phase classes, modelling ResIndSeries.
There was a problem hiding this comment.
I guess this is my fault :-) When I made the first commit I came up with this name but I agree with your comment. SeriesRL would be better indeed.
| if (auto mnasubcomp = std::dynamic_pointer_cast<MNAInterface>(subcomp)) | ||
| mnasubcomp->mnaApplySystemMatrixStamp(systemMatrix); | ||
|
|
||
| if (terminalNotGrounded(0)) { |
There was a problem hiding this comment.
I think we can log this in the same place that the code is (with the equations) on line 221
This PR implements a new component "ResIndSeries" in the SP, DP and EMT (3Ph) domains which models the series connection of a resistor with an inductor. The new component is validated against a RLC solved using the basic components (R, L, C) of DPsim. Moreover, virtual nodes and snubber components of PiLines and PowerTransformers are removed to improve the performance and accuracy of simulations.