Update WSCC_9bus_mult examples and implement splitting examples in DP and EMT #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pipeacosta <[email protected]>
with Notebook WSCC_9bus_parallel.ipynb. Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
pipeacosta
requested review from
m-mirz,
stv0g,
gnakti,
leonardocarreras and
dinkelbachjan
as code owners
Signed-off-by: pipeacosta <[email protected]>
gnakti
requested changes
Oct 29, 2024
Comment on lines
203
to
208
| - name: Run Binaries 2/2 | ||
| run: ./build/dpsim/examples/cxx/WSCC_9bus_split_decoupled | ||
|
|
||
| - name: Run Binaries 2/2 | ||
| run: ./build/dpsim/examples/cxx/WSCC_9bus_split_decoupled_EMT | ||
|
|
There was a problem hiding this comment.
@leonardocarreras should we make it also part of build_test_linux_rocky_profiling?
There was a problem hiding this comment.
It could be included here too (sounds like a nice suggestion), I would not consider it as blocking issue as we are not running it on every push request
dpsim/.github/workflows/build_test_linux_rocky_profiling.yaml
Lines 40 to 54 in d66f826
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the examples
WSCC_9bus_mult_coupled.cppandWSCC_9bus_mult_decoupled.cppdon't work when thecopiesoption is greater than zero, due toclone()methods missing in some components. Additionally, theWSCC_9bus_parallel.ipynbNotebook must be fixed because it does not find the CIM files of the scenario. Finally, we want to implement a similar Noteboook, based on the python script decoupling_9bus_existing.py for testing the process for splitting the WSCC 9 bus system using a decoupling line in both the DP and the EMT domains.