Skip to content

Optimize http parser. #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barenboim merged 1 commit into from
Sep 23, 2025
Merged

Optimize http parser. #1781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/protocol/http_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,20 +275,31 @@ static int __parse_start_line(const char *ptr, size_t len,
if (ptr[i + 1] != '\n')
return -2;

start_line[i] = '\0';
len = i;
while (len > 0 && start_line[len - 1] == ' ')
len--;

start_line[len] = '\0';
p1 = start_line;
while (*p1 == ' ')
p1++;

p2 = strchr(p1, ' ');
if (p2)
*p2++ = '\0';
else
if (!p2)
return -2;

*p2++ = '\0';
while (*p2 == ' ')
p2++;

p3 = strchr(p2, ' ');
if (p3)
*p3++ = '\0';
else
if (!p3)
return -2;

*p3++ = '\0';
while (*p3 == ' ')
p3++;

if (parser->is_resp)
ret = __match_status_line(p1, p2, p3, parser);
else
Expand All @@ -302,7 +313,7 @@ static int __parse_start_line(const char *ptr, size_t len,
return 1;
}

if (start_line[i] == 0)
if (start_line[i] == '\0')
return -2;
}

Expand Down