Skip to content

Disable getting connection after server task callback. #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barenboim merged 2 commits into from
Jan 9, 2026
Merged

Disable getting connection after server task callback. #1803

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22572dc
Disable getting connection after server task callback.
Barenboim Jan 8, 2026
5f1e3da
Fix get_connection() errno when noreply.
Barenboim Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions src/factory/WFTask.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class WFClientTask : public WFNetworkTask<REQ, RESP>
protected:
virtual CommMessageOut *message_out()
{
/* By using prepare function, users can modify the request after
/* By setting 'prepare' function, users can modify the request after
* the connection is established. */
if (this->prepare)
this->prepare(this);
Expand Down Expand Up @@ -108,7 +108,7 @@ class WFServerTask : public WFNetworkTask<REQ, RESP>
protected:
virtual CommMessageOut *message_out()
{
/* By using prepare function, users can modify the response before
/* By setting 'prepare' function, users can modify the response before
* replying to the client. */
if (this->prepare)
this->prepare(this);
Expand All @@ -120,16 +120,12 @@ protected:
virtual void handle(int state, int error);

protected:
/* CommSession::get_connection() is supposed to be called only in the
* implementations of it's virtual functions. As a server task, to call
* this function after process() and before callback() is very dangerous
* and should be blocked. */
virtual WFConnection *get_connection() const
{
if (this->processor.task)
if (this->processor.task == this)
return (WFConnection *)this->CommSession::get_connection();

errno = EPERM;
errno = this->processor.task ? ENOTCONN : EPERM;
return NULL;
}

Expand All @@ -138,14 +134,13 @@ protected:
{
if (this->state == WFT_STATE_TOREPLY)
{
/* Enable get_connection() again if the reply() call is success. */
this->processor.task = this;
if (this->scheduler->reply(this) >= 0)
return;

this->state = WFT_STATE_SYS_ERROR;
this->error = errno;
this->processor.task = NULL;
this->processor.task = (WFServerTask *)-1;
}
else
this->scheduler->shutdown(this);
Expand All @@ -166,15 +161,15 @@ protected:
if (this->callback)
this->callback(this);

/* Defer deleting the task. */
this->processor.task = NULL;
return series->pop();
}

protected:
class Processor : public SubTask
{
public:
Processor(WFServerTask<REQ, RESP> *task,
Processor(WFServerTask *task,
std::function<void (WFNetworkTask<REQ, RESP> *)>& proc) :
process(proc)
{
Expand All @@ -184,7 +179,7 @@ protected:
virtual void dispatch()
{
this->process(this->task);
this->task = NULL; /* As a flag. get_conneciton() disabled. */
this->task = NULL; /* As a flag, disable getting connection. */
this->subtask_done();
}

Expand All @@ -194,13 +189,13 @@ protected:
}

std::function<void (WFNetworkTask<REQ, RESP> *)>& process;
WFServerTask<REQ, RESP> *task;
WFServerTask *task;
} processor;

class Series : public SeriesWork
{
public:
Series(WFServerTask<REQ, RESP> *task) :
Series(WFServerTask *task) :
SeriesWork(&task->processor, nullptr)
{
this->set_last_task(task);
Expand All @@ -212,7 +207,7 @@ protected:
delete this->task;
}

WFServerTask<REQ, RESP> *task;
WFServerTask *task;
};

public:
Expand Down