Skip to content

Commit

Permalink
Fix to guard against no additional python kernels to register
Browse files Browse the repository at this point in the history
  • Loading branch information
tnederlof committed Apr 29, 2023
1 parent 7766660 commit 55d9393
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions internal/jupyter/prompt.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,17 @@ func ScanPromptInstallAndConfigJupyter() error {
pythonVersionsLeft := removeString(pythonVersions, jupyterPythonTarget)
// remove any non opt locations from the default selections
defaultPythonVersions := removeNonOptPython(pythonVersionsLeft)
additionalPythonTargets, err := AdditionalKernelPrompt(pythonVersionsLeft, defaultPythonVersions)
if err != nil {
return fmt.Errorf("issue selecting additional Python kernels to register: %w", err)
}
// if one or more versions is selected then automatically register them
if len(additionalPythonTargets) > 0 {
err = RegisterJupyterKernels(additionalPythonTargets)
if len(pythonVersionsLeft) > 0 {
additionalPythonTargets, err := AdditionalKernelPrompt(pythonVersionsLeft, defaultPythonVersions)
if err != nil {
return fmt.Errorf("issue registering additional Python kernels: %w", err)
return fmt.Errorf("issue selecting additional Python kernels to register: %w", err)
}
// if one or more versions is selected then automatically register them
if len(additionalPythonTargets) > 0 {
err = RegisterJupyterKernels(additionalPythonTargets)
if err != nil {
return fmt.Errorf("issue registering additional Python kernels: %w", err)
}
}
}
}
Expand Down

0 comments on commit 55d9393

Please sign in to comment.