Skip to content

Update ahash to 0.8.7#2850

Closed
moxw wants to merge 1 commit intosolana-foundation:masterfrom
moxw:fix/upgrade-ahash
Closed

Update ahash to 0.8.7#2850
moxw wants to merge 1 commit intosolana-foundation:masterfrom
moxw:fix/upgrade-ahash

Conversation

@moxw
Copy link

@moxw moxw commented Mar 17, 2024

Fresh installation of anchor was breaking, this should fix it.

Problem


error[E0635]: unknown feature stdsimd
  --> /home/mohit/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.6/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^`

Solution

tkaitchuck/aHash#200
tkaitchuck/aHash#183

@vercel
Copy link

vercel bot commented Mar 17, 2024

@moxw is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added the dependencies Pull requests that update a dependency file label Mar 17, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR but we don't have direct dependency to ahash, the line you changed was added as a temporary fix until we can upgrade to solana-cli 1.18, and will be removed afterwards.

Also, this change was never published as a release — are you using the git version?

@moxw
Copy link
Author

moxw commented Mar 17, 2024

@acheroncrypto I was installing using avm install 0.29.0

@zilayo
Copy link
Contributor

zilayo commented Mar 17, 2024

yes avm install latest currently isn't working due to the above issue

@moxw
Copy link
Author

moxw commented Mar 17, 2024

@zilayo try this cargo install --git https://github.com/coral-xyz/anchor --tag v0.29.0 anchor-cli --force

i think avm install not adding the tag properly

@zilayo
Copy link
Contributor

zilayo commented Mar 17, 2024

@zilayo try this cargo install --git https://github.com/coral-xyz/anchor --tag v0.29.0 anchor-cli --force

i think avm install not adding the tag properly

thanks that works.

Also got avm install latest to work by switching from nightly 1.78 -> stable 1.76

@acheroncrypto
Copy link
Collaborator

This dependency has been removed in #2867.

@moxw moxw deleted the fix/upgrade-ahash branch April 14, 2024 04:11
@brandonros
Copy link

https://github.com/coral-xyz/anchor/blob/master/Cargo.lock#L66-L75

ahash 0.7.6 needs to be bumped/pinned to https://github.com/tkaitchuck/aHash/releases/tag/v0.7.8, idl-build is still broken for me as of 2024-05-31 on 0.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments