Open
Conversation
lgalabru
force-pushed
the
feat/revisit-scenario
branch
from
6e73a76 to
3ad3607
Compare
Replace the large verified_tokens.json (49k lines) with a compact CSV format, reducing file size significantly and simplifying token parsing.
Rework scenario type definitions and registry to support new protocol configurations, improved override handling, and generation scripts.
Add Raydium v4, SPL Token, and Switchboard v2 protocol support. Update overrides for Kamino, Pyth v2, Raydium v3, and Whirlpool. Include generation scripts for Pyth price feeds and Raydium markets, and add a Kamino liquidation arbitrage example.
Update SVM runtime, locker, and cheatcodes to support the new scenario protocol configurations and override processing.
Adapt MCP server tools and handlers to work with the updated scenario types and protocol configurations.
Add CLI support for revised scenario commands and update workspace dependency versions.
lgalabru
force-pushed
the
feat/revisit-scenario
branch
from
3ad3607 to
9cb2398
Compare
MicaiahReid
requested changes
Mar 12, 2026
| - id: "sol-pippin" | ||
| label: "SOL/pippin" | ||
| value: "4Zm2A7VUfuvudpVpQkJyrg2DiZTcw6ckwbKP9LvizAkx" | ||
| description: "SOL/pippin AMM v4 pool (30d vol: $593.1M)" |
Collaborator
There was a problem hiding this comment.
All of the (30d vol: ) comments I think are not useful/relevant here
| let resolved_path = super::resolve_path(snapshot_path); | ||
| let path_str = resolved_path.to_string_lossy(); | ||
| info!("Restoring state from snapshot: {}", path_str); | ||
| match surfnet_svm.restore_from_snapshot(&path_str) { |
Collaborator
There was a problem hiding this comment.
We have a very similar code path to surfnet_svm.restore_from_snapshot at https://github.com/txtx/surfpool/blob/9cb2398b2cf5caf1969aa9715bcb5a45e7c4c49e/crates/core/src/surfnet/locker.rs#L481
It is initialized a few lines below this (line 89 of this file) where the snapshot file contents are processed and stored on the simnet config.
That one does a few extra things - allowing useres to provide <pubkey>: null in their snapshot to fetch from remote.
Is this current loop causing a double import? Do we want to go with just one of these approaches?
| // SWITCHBOARD_ON_DEMAND_OVERRIDES_CONTENT, | ||
| // "switchboard-v2", | ||
| // ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we're bringing
Scenarioa bit closer to the finish line, but we still have a lot of remaining work to wrap up this epic.