feat(cli): allow passing feature pubkey instead of name on startup#577
Merged
MicaiahReid merged 4 commits intomainfrom Mar 19, 2026
Merged
feat(cli): allow passing feature pubkey instead of name on startup#577MicaiahReid merged 4 commits intomainfrom
MicaiahReid merged 4 commits intomainfrom
Conversation
MicaiahReid
changed the title
lgalabru
approved these changes
Mar 19, 2026
Collaborator
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Awesome finding, thanks for the clean-up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
83ab44a - feature accounts didn't exist in VM at runtime (when referenced in a program), because litesvm doesn't store them. Temporary fix until litesvm fix is in. Issue to remove todo's
7ee8fe2 - litesvm references
feature_sets injected fromwith_feature_setin subsequentwith_builtins,with_sysvars, andwith_default_programscalls. So, when we update feature sets, call these fnse5336bf - Update
--feature <kebab-case-feature-name>to take--feature <pubkey>. This should prevent breaking the feature name for now, but we'll be able to remove a bunch of code once we deprecate that feature. I've added the deprecation notice to the CLI flags