Temporarily use stable clippy for redundant_clone#31692
Temporarily use stable clippy for redundant_clone#31692mergify[bot] merged 1 commit intosolana-labs:masterfrom
Conversation
ryoqun
force-pushed
the
good-old-clippy
branch
2 times, most recently
from
ec8d694 to
117ea40
Compare
|
see! this pr is working! seems #31690 wasn't merged yet (i did afterwards): https://buildkite.com/solana-labs/solana/builds/95758#018829a7-7090-4ce1-8693-2ad0c0100f1c/1717-2374
|
|
seems ci is green, adding automerge. :) i had some fruitful debugging session diving into rust/clippy: |
|
I think this one is good but I defer to Tyera. 🫶 |
There was a problem hiding this comment.
It isn't the best that we have to run clippy twice, but I guess I'm okay with the band-aid. Can you please create an issue linking to the clippy issue so that we can track when it's fixed and simplify this job again?
What's the argument for running nightly clippy everywhere, incidentally? The comment only refers to sdk. It would also be nice to document what nightly-only code we're actually using there.
|
(Thank you for jumping on this, btw!) |
beep beep (next in my loong task queue). I'm hearing! |
hi, I'm reporting back!
done: #31834
done: #31833 |
3 participants
Problem
I disabled rather useful clippy lint altogether at #31381 , causing some trouble around bp-ing. ref: #31690
Summary of Changes
Restore the functionary with somewhat degraded state as a band-aid fix for now..
namely,
checkwill take extra minutes, but i think it's acceptable.upstream bug: rust-lang/rust-clippy#10577