Skip to content

deps: Bump to Solana v2.2#44

Merged
joncinque merged 4 commits intosolana-program:mainfrom
joncinque:bumpsolana
Mar 3, 2025
Merged

deps: Bump to Solana v2.2#44
joncinque merged 4 commits intosolana-program:mainfrom
joncinque:bumpsolana

Conversation

@joncinque
Copy link
Contributor

Problem

The repo is still on v2.1 Solana

Summary of changes

Bump everything to v2.2

@joncinque joncinque enabled auto-merge (squash) February 19, 2025 22:14
@joncinque joncinque disabled auto-merge February 19, 2025 22:35
@joncinque
Copy link
Contributor Author

@buffalojoec I also had to enable the borsh feature on solana-program-error to go with the derive feature spl-type-length-value. Since the From<io::Error> for ProgramError implementation is only available with the borsh feature on solana-program-error.

Since type-length-value-derive only derives the borsh trait, it seems logical to just enable any other crates' borsh features at the same time, but let me know if you have a better idea!

@buffalojoec
Copy link
Contributor

@buffalojoec I also had to enable the borsh feature on solana-program-error to go with the derive feature spl-type-length-value. Since the From<io::Error> for ProgramError implementation is only available with the borsh feature on solana-program-error.

Since type-length-value-derive only derives the borsh trait, it seems logical to just enable any other crates' borsh features at the same time, but let me know if you have a better idea!

I think that makes sense! Looking at the macro implementation, it looks like more trouble than it's worth to make borsh an optional implementation for the underlying methods on the trait.

@joncinque
Copy link
Contributor Author

It looks like there's an issue in the current spl-pod version, and this PR will fix those issues.

I'll publish spl-pod to resolve the CI issue once this lands, so if there's no issues, can you approve?

@joncinque joncinque enabled auto-merge (squash) March 3, 2025 09:35
@joncinque joncinque merged commit 9439496 into solana-program:main Mar 3, 2025
23 of 24 checks passed
@joncinque joncinque deleted the bumpsolana branch March 3, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants