Merged
Conversation
#### Problem We need to publish new versions of some crates, such as spl-pod, but there's no automated publishing job on the repo yet. #### Summary of changes Following the model of the token-2022 repo, add a publish job and accompanying scripts.
febo
reviewed
Mar 3, 2025
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Do you think we need to have the semver here? At the moment, semver runs on the "main" workflow, but this would not necessarily guarantee that the version being published follows semver.
Contributor
Author
|
Can we add it later? Since the semver job is already failing, I'm not too keen to add it here and have the publishes fail immediately 😅 |
Contributor
Yeah, definitely, let's leave it to a separate PR. I was thinking more in the lines of how it is done in pinocchio, where the semver checks whether the version bump is correct before the publishing using the "future" version number. |
febo
approved these changes
Mar 4, 2025
joncinque
added a commit
to joncinque/single-pool
that referenced
this pull request
Mar 11, 2025
#### Problem It's time to publish some single-pool crates, but it's still using some of the older repo setup. It can only publish clients, it has a lot of copied scripts, the semver check runs on everything, etc etc #### Summary of changes Similar to solana-program/libraries#50, but for the single-pool repo
joncinque
added a commit
to solana-program/single-pool
that referenced
this pull request
Mar 11, 2025
* CI: Update like the other repos #### Problem It's time to publish some single-pool crates, but it's still using some of the older repo setup. It can only publish clients, it has a lot of copied scripts, the semver check runs on everything, etc etc #### Summary of changes Similar to solana-program/libraries#50, but for the single-pool repo * Fixups * Fixup nightly toolchain * Fixup scripts * Fix js legacy test * Add build step properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need to publish new versions of some crates, such as spl-pod, but there's no automated publishing job on the repo yet.
Summary of changes
Following the model of the token-2022 repo, add a publish job and accompanying scripts.