tlv: Enable solana-pubkey feature, add testing#54
Merged
joncinque merged 3 commits intosolana-program:mainfrom Mar 4, 2025
Merged
tlv: Enable solana-pubkey feature, add testing#54joncinque merged 3 commits intosolana-program:mainfrom
joncinque merged 3 commits intosolana-program:mainfrom
Conversation
#### Problem The tlv-account-resolution library currently fails to build `cargo check` because the `curve25519` feature is not enabled. #### Summary of changes Enable the feature. At the same time, add a CI step for running `cargo hack check --all-features` on the repo to catch this.
buffalojoec
approved these changes
Mar 4, 2025
Contributor
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Looks good, and I like the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tlv-account-resolution library currently fails to build
cargo checkbecause thecurve25519feature is not enabled.Summary of changes
Enable the feature. At the same time, add a CI step for running
cargo hack check --all-featureson the repo to catch this.I also got a little annoyed about all the redundant toolchain declarations that are all just the nightly toolchain, so I combined them all for the hack step.