CI: Move semver check to publish job#57
Merged
joncinque merged 1 commit intosolana-program:mainfrom Mar 8, 2025
Merged
Conversation
#### Problem The semver check job can be a bit noisy and give a lot of negatives, which can hamper development. #### Summary of changes Run the semver checks only during publish, similar to how pinocchio does things.
joncinque
added a commit
to joncinque/token-metadata
that referenced
this pull request
Mar 21, 2025
#### Problem Similar to solana-program/libraries#57 but for the token-metadata repo. #### Summary of changes Move semver checks to happen during publish.
joncinque
added a commit
to solana-program/token-metadata
that referenced
this pull request
Mar 24, 2025
* CI: Move semver check to publish step #### Problem Similar to solana-program/libraries#57 but for the token-metadata repo. #### Summary of changes Move semver checks to happen during publish. * Remove the script * Use the pinocchio way * Make publish depend on semver * Add more version options, fix inputs.crate * Remove space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The semver check job can be a bit noisy and give a lot of negatives, which can hamper development.
Summary of changes
Run the semver checks only during publish, similar to how pinocchio does things.