Skip to content

use taiki-e for cargo release install#74

Merged
2501babe merged 2 commits intosolana-program:mainfrom
2501babe:cargo-rel-hotfix
Apr 14, 2025
Merged

use taiki-e for cargo release install#74
2501babe merged 2 commits intosolana-program:mainfrom
2501babe:cargo-rel-hotfix

Conversation

@2501babe
Copy link
Member

@2501babe 2501babe commented Apr 14, 2025

from crate publish dryrun:

Run which cargo-release || cargo install cargo-release
  which cargo-release || cargo install cargo-release
  shell: /usr/bin/bash -e {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    SOLANA_VERSION: [2](https://github.com/solana-program/libraries/actions/runs/14447836275/job/40512827106#step:5:2).2.0
    TOOLCHAIN_NIGHTLY: nightly-2024-11-22
info: syncing channel updates for '1.84.1-x86_64-unknown-linux-gnu'
...
    Updating crates.io index
error: cannot install package `cargo-release 0.25.18`, it requires rustc 1.85 or newer, while the currently active rustc version is 1.84.1
`cargo-release 0.25.17` supports rustc 1.82
Error: Process completed with exit code 101.

since we are advancing our rust_toolchain.toml in line with (agave? sdk? one of the ex-monorepos) it seems more prudent to temporarily downgrade this than mess with that

@2501babe 2501babe marked this pull request as ready for review April 14, 2025 14:32
@2501babe 2501babe self-assigned this Apr 14, 2025
@2501babe 2501babe requested a review from joncinque April 14, 2025 14:32
@joncinque
Copy link
Contributor

As another option, we could use https://github.com/anza-xyz/solana-sdk/blob/f7a6475ae883e0216eaeab42f525833f667965a0/.github/workflows/main.yml#L156 to install it, what do you think?

@2501babe
Copy link
Member Author

cool, ill give that a try and if it doesnt work just merge this instead

@2501babe 2501babe merged commit cf4fe04 into solana-program:main Apr 14, 2025
29 checks passed
@2501babe 2501babe deleted the cargo-rel-hotfix branch April 14, 2025 15:16
@2501babe
Copy link
Member Author

good to go 🫡

@2501babe 2501babe changed the title temp downgrade cargo release use taiki-e for cargo release install Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants