ci(release): fix artifact flatten (download-artifact merge-multiple) - #3
Merged
Merged
Conversation
The flatten step moved each downloaded artifact file back into its own same-named directory, leaving dist/safe-ai-skill-<plat> as directories and breaking 'sha256sum ... > SHA256SUMS' (Is a directory). Use merge-multiple: true so artifacts land directly in dist/. Same fix applied to the vendor-binaries job. Verified locally that SHA256SUMS generation and sha256sum -c both pass against the flattened layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the v1.0.0 release run failure at 'Generate SHA256SUMS':
sha256sum: safe-ai-skill-darwin-arm64: Is a directory
Cause: actions/download-artifact@v4 places each artifact in dist//. The old flatten (find -mindepth 2 -exec mv {} dist/) moved each file back into its own same-named directory, so dist/safe-ai-skill- stayed a directory.
Fix: download-artifact with merge-multiple: true → all artifacts land directly in dist/, no flatten, no collision. Applied to both the release job and the vendor-binaries job.
Tested locally: simulated the flattened layout and confirmed both the release SHA256SUMS generation and the vendor staging + 'sha256sum -c' pass.
No GitHub Release was created by the failed run (it died before 'gh release create'). After merge: move the v1.0.0 tag to the new main tip and push to re-trigger the release.