Skip to content

fix: hard-fail em-dash overuse - #2

Open
abhinavgautam01 wants to merge 1 commit into
solanabr:mainfrom
abhinavgautam01:fix/hard-fail-em-dash-overuse
Open

fix: hard-fail em-dash overuse#2
abhinavgautam01 wants to merge 1 commit into
solanabr:mainfrom
abhinavgautam01:fix/hard-fail-em-dash-overuse

Conversation

@abhinavgautam01

Copy link
Copy Markdown

Summary

Fixes #1

This makes em-dash overuse a hard tells failure instead of an advisory warning.

Changes

  • Treat em-dash overuse as a hard tell in validate_voice.py
  • Make the tells CLI exit non-zero when the em-dash cap is exceeded
  • Keep the existing rate-and-count guard so a single em dash in a short passage does not fail
  • Update validator selftests to assert em-dash overuse is hard
  • Update docs to match the new hard-fail behavior

Verification

  • python3 skills/writer-style/tools/test_tools.py
  • focused CLI check: over-cap em-dashes return [HARD], GATE: FAIL, exit 1
  • focused CLI check: a single em dash still returns GATE: PASS, exit 0
  • git diff --check
  • npm_config_cache=/tmp/writer-style-npm-cache npm pack --dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

em-dash flag is advisory only - get rid of this slop

1 participant