Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-40928 - Removed containerid from k8s struct #2

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

jerrytfleung
Copy link
Contributor

@jerrytfleung jerrytfleung commented Jul 10, 2023

Description of changes:

  • It turns out that the containerid information is unnecessary for host-trace matching as it will be based on Pod information.
  • Removed this field ASAP when we don't release to production yet.

Related issues

NH-40928

@jerrytfleung jerrytfleung requested review from cheempz, cleverchuk and a team July 10, 2023 22:01
@jerrytfleung jerrytfleung merged commit 294e9af into main Jul 10, 2023
@jerrytfleung jerrytfleung deleted the NH-40928 branch July 10, 2023 22:59
@cheempz
Copy link
Contributor

cheempz commented Jul 10, 2023

Thanks @jerrytfleung. To be clear, the pod UID will be used for correlating APM Service to K8s at the pod level, but if our instrumentation is able to report container ID, there will be additional correlation between at the container level. So we do need the container ID field, just that we're asking instrumentation core libraries to set it in the existing HostID.dockerContainerID field, and for ingestion to use that field cc @gglogowski.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants