Remove obsolete gas cost tiers

- They're no longer used because the cost depends on the EVM version.
solidity-docs · Feb 19, 2024 · f518815 · f518815
1 parent 18cabee
commit f518815
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 22 deletions.
diff --git a/libevmasm/Assembly.cpp b/libevmasm/Assembly.cpp
@@ -29,7 +29,6 @@
 #include <libevmasm/JumpdestRemover.h>
 #include <libevmasm/BlockDeduplicator.h>
 #include <libevmasm/ConstantOptimiser.h>
-#include <libevmasm/GasMeter.h>
 
 #include <liblangutil/CharStream.h>
 #include <liblangutil/Exceptions.h>

diff --git a/libevmasm/GasMeter.cpp b/libevmasm/GasMeter.cpp
@@ -274,18 +274,20 @@ unsigned GasMeter::runGas(Instruction _instruction, langutil::EVMVersion _evmVer
 
 	switch (instructionInfo(_instruction, _evmVersion).gasPriceTier)
 	{
-	case Tier::Zero:		return GasCosts::tier0Gas;
-	case Tier::Base:		return GasCosts::tier1Gas;
-	case Tier::VeryLow:		return GasCosts::tier2Gas;
-	case Tier::Low:			return GasCosts::tier3Gas;
-	case Tier::Mid:			return GasCosts::tier4Gas;
-	case Tier::High:		return GasCosts::tier5Gas;
-	case Tier::Ext:			return GasCosts::tier6Gas;
-	case Tier::WarmAccess:	return GasCosts::warmStorageReadCost;
-	default: break;
+	case Tier::Zero:        return GasCosts::tier0Gas;
+	case Tier::Base:        return GasCosts::tier1Gas;
+	case Tier::VeryLow:     return GasCosts::tier2Gas;
+	case Tier::Low:         return GasCosts::tier3Gas;
+	case Tier::Mid:         return GasCosts::tier4Gas;
+	case Tier::High:        return GasCosts::tier5Gas;
+	case Tier::Ext:         return GasCosts::tier6Gas;
+	case Tier::WarmAccess:  return GasCosts::warmStorageReadCost;
+
+	case Tier::Special:
+	case Tier::Invalid:
+		assertThrow(false, OptimizerException, "Invalid gas tier for instruction " + instructionInfo(_instruction, _evmVersion).name);
 	}
-	assertThrow(false, OptimizerException, "Invalid gas tier for instruction " + instructionInfo(_instruction, _evmVersion).name);
-	return 0;
+	util::unreachable();
 }
 
 u256 GasMeter::dataGas(bytes const& _data, bool _inCreation, langutil::EVMVersion _evmVersion)

diff --git a/libevmasm/Instruction.cpp b/libevmasm/Instruction.cpp
@@ -211,7 +211,7 @@ static std::map<Instruction, InstructionInfo> const c_instructionInfo =
 	{ Instruction::SIGNEXTEND,	{ "SIGNEXTEND",		0, 2, 1, false, Tier::Low } },
 	{ Instruction::KECCAK256,	{ "KECCAK256",			0, 2, 1, true, Tier::Special } },
 	{ Instruction::ADDRESS,		{ "ADDRESS",		0, 0, 1, false, Tier::Base } },
-	{ Instruction::BALANCE,		{ "BALANCE",		0, 1, 1, false, Tier::Balance } },
+	{ Instruction::BALANCE,     { "BALANCE",        0, 1, 1, false, Tier::Special } },
 	{ Instruction::ORIGIN,		{ "ORIGIN",			0, 0, 1, false, Tier::Base } },
 	{ Instruction::CALLER,		{ "CALLER",			0, 0, 1, false, Tier::Base } },
 	{ Instruction::CALLVALUE,	{ "CALLVALUE",		0, 0, 1, false, Tier::Base } },
@@ -221,12 +221,12 @@ static std::map<Instruction, InstructionInfo> const c_instructionInfo =
 	{ Instruction::CODESIZE,	{ "CODESIZE",		0, 0, 1, false, Tier::Base } },
 	{ Instruction::CODECOPY,	{ "CODECOPY",		0, 3, 0, true, Tier::VeryLow } },
 	{ Instruction::GASPRICE,	{ "GASPRICE",		0, 0, 1, false, Tier::Base } },
-	{ Instruction::EXTCODESIZE,	{ "EXTCODESIZE",	0, 1, 1, false, Tier::ExtCode } },
-	{ Instruction::EXTCODECOPY,	{ "EXTCODECOPY",	0, 4, 0, true, Tier::ExtCode } },
-	{ Instruction::RETURNDATASIZE,	{"RETURNDATASIZE",	0, 0, 1, false, Tier::Base } },
-	{ Instruction::RETURNDATACOPY,	{"RETURNDATACOPY",	0, 3, 0, true, Tier::VeryLow } },
+	{ Instruction::EXTCODESIZE, { "EXTCODESIZE",    0, 1, 1, false, Tier::Special } },
+	{ Instruction::EXTCODECOPY, { "EXTCODECOPY",    0, 4, 0, true, Tier::Special } },
+	{ Instruction::RETURNDATASIZE, {"RETURNDATASIZE", 0, 0, 1, false, Tier::Base } },
+	{ Instruction::RETURNDATACOPY, {"RETURNDATACOPY", 0, 3, 0, true, Tier::VeryLow } },
 	{ Instruction::MCOPY,       { "MCOPY",          0, 3, 0, true, Tier::VeryLow } },
-	{ Instruction::EXTCODEHASH,	{ "EXTCODEHASH",	0, 1, 1, false, Tier::Balance } },
+	{ Instruction::EXTCODEHASH, { "EXTCODEHASH",    0, 1, 1, false, Tier::Special } },
 	{ Instruction::BLOCKHASH,	{ "BLOCKHASH",		0, 1, 1, false, Tier::Ext } },
 	{ Instruction::BLOBHASH,    { "BLOBHASH",       0, 1, 1, false, Tier::VeryLow } },
 	{ Instruction::COINBASE,	{ "COINBASE",		0, 0, 1, false, Tier::Base } },

diff --git a/libevmasm/Instruction.h b/libevmasm/Instruction.h
@@ -297,8 +297,6 @@ enum class Tier
 	High,		// 10, Slow
 	Ext,		// 20, Ext
 	WarmAccess,	// 100, Warm Access
-	ExtCode,	// 700, Extcode
-	Balance,	// 400, Balance
 	Special,	// multiparam or otherwise special
 	Invalid		// Invalid.
 };

diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp
@@ -43,9 +43,7 @@
 
 #include <libyul/YulStack.h>
 
-#include <libevmasm/Instruction.h>
 #include <libevmasm/Disassemble.h>
-#include <libevmasm/GasMeter.h>
 
 #include <liblangutil/Exceptions.h>
 #include <liblangutil/SourceReferenceFormatter.h>