Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin UI views to work with solidus admin 4.4 #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boomer196
Copy link
Contributor

@boomer196 boomer196 commented Dec 3, 2024

  • Fixed a deprecation warning on using product_sub_menu.
DEPRECATION WARNING: Using the "spree/admin/shared/_product_sub_menu" partial is deprecated, please use MenuItem#children instead.
  • Updates the admin views of this gem to work with soldius admin v 4.4.
    • The order menu was wrong anyway, so it wasn't showing the icon (fa-icon-cloud should have been fa-cloud)

Screenshots

Before

  • Products tab (This bulleted list was caused by deprecated partial)
image
  • Orders tab
    image
  • Digital Versions tab
    image
  • Digital Link rows
    image

After

  • Orders tab
    image
  • Digital Versions tab
    image
  • Digital Link rows
    image

@fthobe
Copy link

fthobe commented Dec 7, 2024

Hey @boomer196 I think @kennyadsl would be more than happy to help you on making the tests work and merge it.

@fthobe
Copy link

fthobe commented Dec 10, 2024

@boomer196 did you take a look why the tests are failing and did you test against 4.4?

@boomer196
Copy link
Contributor Author

@boomer196 did you take a look why the tests are failing and did you test against 4.4?

Tests should be green (they are locally). There may be some rubocop violations, (which I have another branch in my fork that fixes these), but I do not think the CircleCI server for this repo is currently working.

Yes, I am currently running/testing my fork in a v4.4.2 store.

I am just putting these PRs out here in case they help someone.

@fthobe
Copy link

fthobe commented Dec 13, 2024

Out of curiosity, does the system tokenize the download or how does it work?

@boomer196 boomer196 force-pushed the update-admin-ui-for-solidus-4.4 branch 3 times, most recently from 19d13d6 to 078ee20 Compare December 16, 2024 19:38
DEPRECATION WARNING: Using the "spree/admin/shared/_product_sub_menu" partial is deprecated, please use MenuItem#children instead.
Solidus admin v4.4 does not use icon links or delete buttons
@boomer196 boomer196 force-pushed the update-admin-ui-for-solidus-4.4 branch from 078ee20 to 62784ee Compare December 16, 2024 20:08
@boomer196
Copy link
Contributor Author

@kennyadsl, this PR is now green and ready to go. Please take a look when you have a chance.

@kennyadsl
Copy link
Member

@boomer196 thanks. One thing is not super clear to me. Did you update the color of the legacy admin to match the color of the new admin? If yes, I don't think it's the right approach to make the extension work with the new admin. Instead, we should create the views for the new admin using the new components.

@boomer196
Copy link
Contributor Author

@kennyadsl , I never saw the old admin, so I am not sure what it used to look like.

Here are the changes:

  • link_to_with_icon was changed to just a link_to, which just removed the "cloud icon" from the tabs.
  • link_to_with_icon was changed to just a link_to_delete, which changed the table row treatment
  • Removed the _product_sub_menu because it is deprecated and it was causing a bulleted list.

@boomer196 boomer196 changed the title Update admin UI to match look-n-feel of solidus admin 4.4 Update admin UI views to work with solidus admin 4.4 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants