Update admin UI views to work with solidus admin 4.4

[boomer196]

• Fixed a deprecation warning on using product_sub_menu.

DEPRECATION WARNING: Using the "spree/admin/shared/_product_sub_menu" partial is deprecated, please use MenuItem#children instead.

• Updates the admin views of this gem to work with soldius admin v 4.4.
  • The order menu was wrong anyway, so it wasn't showing the icon (fa-icon-cloud should have been fa-cloud)

Screenshots

Before

• Products tab (This bulleted list was caused by deprecated partial)

• Orders tab
  
• Digital Versions tab
  
• Digital Link rows
  

After

• Orders tab
  
• Digital Versions tab
  
• Digital Link rows
  

[fthobe]

Hey @boomer196 I think @kennyadsl would be more than happy to help you on making the tests work and merge it.

[fthobe]

@boomer196 did you take a look why the tests are failing and did you test against 4.4?

[boomer196]

@boomer196 did you take a look why the tests are failing and did you test against 4.4?

Tests should be green (they are locally). There may be some rubocop violations, (which I have another branch in my fork that fixes these), but I do not think the CircleCI server for this repo is currently working.

Yes, I am currently running/testing my fork in a v4.4.2 store.

I am just putting these PRs out here in case they help someone.

[fthobe]

Out of curiosity, does the system tokenize the download or how does it work?

[boomer196]

@kennyadsl, this PR is now green and ready to go. Please take a look when you have a chance.

[kennyadsl]

@boomer196 thanks. One thing is not super clear to me. Did you update the color of the legacy admin to match the color of the new admin? If yes, I don't think it's the right approach to make the extension work with the new admin. Instead, we should create the views for the new admin using the new components.

[boomer196]

@kennyadsl , I never saw the old admin, so I am not sure what it used to look like.

Here are the changes:

• link_to_with_icon was changed to just a link_to, which just removed the "cloud icon" from the tabs.
• link_to_with_icon was changed to just a link_to_delete, which changed the table row treatment
• Removed the _product_sub_menu because it is deprecated and it was causing a bulleted list.

[fthobe]

@boomer196 this can be closed now, correct?

[boomer196]

I believe it is still a valid UI upgrade. However, I am not sure about older versions of the admin (<v4.4). I will defer to @kennyadsl I am fine either way. I gave maintainers edit permission on the PR, so they can either merge it or close it. I will let it sit for another week or so and then I will close it otherwise. Thanks for the reminder (I forgotten about this PR as I have decided not to use this extension).

[fthobe]

Hey, i thought everything was squashed with your merged PR. If it's ok we clone your branch and finish it up.

[fthobe]

@kennyadsl looks good