Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: engine initialization prevented overrides in Solidus v4.4 #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BUGFIX: engine initialization prevented overrides in Solidus v4.4 #30

wants to merge 1 commit into from

Conversation

boomer196
Copy link
Contributor

@boomer196 boomer196 commented Dec 13, 2024 •
edited
Loading

While testing with solidus v4.4, I was getting an exception trying to override configuration:

uninitialized constant Spree::DigitalConfiguration (NameError)

  Spree::DigitalConfiguration[:authorized_clicks] = nil
       ^^^^^^^^^^^^^^^^^^^^^^
Did you mean?  Spree::SpreeDigitalConfiguration

There were changes made in PR #26 that I believe broke this. While the engine "ran".....it couldn't be "configured"

This PR is a hybrid between what was there before that PR and what is required to work in v4.4

@boomer196 boomer196 force-pushed the fix-engine-initializer-for-configuration branch 4 times, most recently from 21c0422 to 967fdad Compare December 16, 2024 20:24
@boomer196 boomer196 force-pushed the fix-engine-initializer-for-configuration branch from 967fdad to f09e397 Compare December 16, 2024 20:38
@boomer196
Copy link
Contributor Author

@kennyadsl, this PR is now green and ready to go. Please take a look when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boomer196