Fix Rubocop offenses in specs

.circleci/config.yml

@@ -11,63 +11,43 @@ orbs:
   solidusio_extensions: solidusio/extensions@volatile
 
 jobs:
-  run-specs:
-    parameters:
-      solidus:
-        type: string
-        default: main
-      db:
-        type: string
-        default: "postgres"
-      ruby:
-        type: string
-        default: "3.2"
-    executor:
-      name: solidusio_extensions/<< parameters.db >>
-      ruby_version: << parameters.ruby >>
+  run-specs-with-sqlite:
+    executor: solidusio_extensions/sqlite
     steps:
-      - checkout
       - browser-tools/install-chrome
-      - solidusio_extensions/run-tests-solidus-<< parameters.solidus >>
-
+      - solidusio_extensions/run-tests
+  run-specs-with-postgres:
+    executor: solidusio_extensions/postgres
+    steps:
+      - browser-tools/install-chrome
+      - solidusio_extensions/run-tests
+  run-specs-with-mysql:
+    executor: solidusio_extensions/mysql
+    steps:
+      - browser-tools/install-chrome
+      - solidusio_extensions/run-tests
   lint-code:
-    executor:
-      name: solidusio_extensions/sqlite
-      ruby_version: "3.0"
+    executor: solidusio_extensions/sqlite-memory
     steps:
       - solidusio_extensions/lint-code
 
 workflows:
   "Run specs on supported Solidus versions":
     jobs:
-      - run-specs:
-          name: &name "run-specs-solidus-<< matrix.solidus >>-ruby-<< matrix.ruby >>-db-<< matrix.db >>"
-          matrix:
-            parameters: { solidus: ["main"], ruby: ["3.2"], db: ["postgres"] }
-      - run-specs:
-          name: *name
-          matrix:
-            parameters: { solidus: ["current"], ruby: ["3.1"], db: ["mysql"] }
-      - run-specs:
-          name: *name
-          matrix:
-            parameters: { solidus: ["older"], ruby: ["3.0"], db: ["sqlite"] }
+      - run-specs-with-sqlite
+      - run-specs-with-postgres
+      - run-specs-with-mysql
       - lint-code
 
-  "Weekly run specs against master":
+  "Weekly run specs against main":
     triggers:
       - schedule:
           cron: "0 0 * * 4" # every Thursday
           filters:
             branches:
               only:
-                - master
+                - main
     jobs:
-      - run-specs:
-          name: *name
-          matrix:
-            parameters: { solidus: ["main"], ruby: ["3.2"], db: ["postgres"] }
-      - run-specs:
-          name: *name
-          matrix:
-            parameters: { solidus: ["current"], ruby: ["3.1"], db: ["mysql"] }
+      - run-specs-with-sqlite
+      - run-specs-with-postgres
+      - run-specs-with-mysql

spec/models/spree/inventory_unit_spec.rb

@@ -18,7 +18,7 @@ module Spree
     end
 
     context 'if the unit is not part of an assembly' do
-      it 'will return the percentage of a line item' do
+      it 'returns the percentage of a line item' do
         expect(subject.percentage_of_line_item).to eql(BigDecimal(1))
       end
     end
@@ -31,7 +31,7 @@ module Spree
         order.create_proposed_shipments
       end
 
-      it 'will return the percentage of a line item' do
+      it 'returns the percentage of a line item' do
         subject.line_item = line_item
         expect(subject.percentage_of_line_item).to eql(BigDecimal(0.5, 2))
       end