-
Notifications
You must be signed in to change notification settings - Fork 16
Add ability to support google manager tracker #10
base: master
Are you sure you want to change the base?
Conversation
dd43aee
to
f6ce890
Compare
@jtapia Would you mind rebasing this? We are swinging back to some extensions with open PRs, and we would like to merge this one (this work is relevant to our interests too). |
118788a
to
cb0f5a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtapia! This looks okay to me, other than the odd indentation.
Do you mind taking a look @kennyadsl?
d08da34
to
c3d3952
Compare
2ce73f9
to
e03efe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having two active trackers is a requirement? If not I think we should try to don’t change the .current API and set the type of existing trackers via the default value of the migration that add the type column. What do you think?
@kennyadsl yes, that's the main idea, to have multiple tracking services at the same time, I made this 3376cb2 to avoid iteration on the views and to avoid changes on |
dc9f137
to
8d1ecb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also, did we have something that auto-mark old trackers as non-active when you activate a new one? Do you think we could need something similar? Maybe into another PR?
db/migrate/20180315164256_add_tracker_type_to_spree_trackers.rb
Outdated
Show resolved
Hide resolved
4256f35
to
28ff366
Compare
@kennyadsl once this is merge, I'll bring these changes jtapia@488dad5 to include facebook pixel |
There is one thing I can't get: this PR is adding the main script for Tag Manager which, as far as I know, only defines a |
1399a63
to
50068a3
Compare
@kennyadsl right, here is the change for that 907fc64#diff-ef80dbd5bb074228fe38463e26a993f6R17 |
126e02e
to
a839dde
Compare
What it does?
tracker_type
tospree_trackers
DBcurrent
methodPreview