Skip to content

Commit

Permalink
[4.2] Limit concurrent-ruby to < 1.3.5
Browse files Browse the repository at this point in the history
The `concurrent-ruby` gem drops a dependency on the `logger` gem, which
Rails 7.0 implicitly depends on. Rails 7.0 is out of bugfix maintenance,
so we won't see another release that has this bug fixed, so for Solidus
4.2 and 4.1 let's just limit `concurrent-ruby` to versions that *do*
depend on `logger`.
  • Loading branch information
mamhoff committed Jan 16, 2025
1 parent 8f41473 commit 62d5c3d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions core/solidus_core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ Gem::Specification.new do |s|
s.add_dependency 'awesome_nested_set', '~> 3.3'
s.add_dependency 'cancancan', ['>= 2.2', '< 4.0']
s.add_dependency 'carmen', '~> 1.1.0'
# Adding a constraint here to make sure Rails 7.0 does not crash on startup
# https://github.com/rails/rails/pull/54264
s.add_dependency 'concurrent-ruby', '< 1.3.5'
s.add_dependency 'discard', '~> 1.0'
s.add_dependency 'friendly_id', '~> 5.0'
s.add_dependency 'image_processing', '~> 1.10'
Expand Down

0 comments on commit 62d5c3d

Please sign in to comment.