Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use at least solidus_support 0.12.0 #6037

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 17, 2024

solidus_support 0.11.0 introduced flickwerk for patch
loading. Somehow this messes with the zeitwerk autoloader
and things acting weird (inflections broken, wrong constant
module nesting, etc.)

0.12.0 reverted flickwerk.

@tvdeyen tvdeyen requested a review from a team as a code owner December 17, 2024 18:41
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 17, 2024
Copy link
Contributor

@MadelineCollier MadelineCollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this, it was really stumping me. Much appreciated 💛 Looks like the error has shifted a bit from its original message I was seeing but the solidus_installer step still fails. Definitely working a bit better now though as some specs can actually run!

@tvdeyen tvdeyen force-pushed the solidus_support-revert_flickwerk branch from 0ebd0ac to 41a0b8b Compare December 17, 2024 19:30
@github-actions github-actions bot added changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Dec 17, 2024
@tvdeyen tvdeyen force-pushed the solidus_support-revert_flickwerk branch from 41a0b8b to b49593b Compare December 17, 2024 19:52
@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 17, 2024

Thanks for working through this, it was really stumping me. Much appreciated 💛 Looks like the error has shifted a bit from its original message I was seeing but the solidus_installer step still fails. Definitely working a bit better now though as some specs can actually run!

Yeah, it's a bit tricky because the rails app template for the solidus installer uses the github main branch of solidus_starter_frontend. I added solidusio/solidus_starter_frontend#394 to fix that

@tvdeyen tvdeyen changed the title TMP: Test solidus_support without flickwerk Use at least solidus_support 0.12.0 Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (77f8302) to head (fc51732).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6037   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         790      790           
  Lines       18224    18224           
=======================================
  Hits        16324    16324           
  Misses       1900     1900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MadelineCollier added a commit to MadelineCollier/solidus that referenced this pull request Dec 18, 2024
Fix pulled from tvdeyen's pr: solidusio#6037

I just want to see if it fixes my PR.
solidus_support 0.11.0 introduced flickwerk for patch
loading. Somehow this messes with the zeitwerk autoloader
and things acting weird (inflections broken, wrong constant
module nesting, etc.)

0.12.0 reverted flickwerk.
Sometimes the modal that contains the field
is not present yet. Let's use capybara's waiting
capabilities before filling the field.
@tvdeyen tvdeyen force-pushed the solidus_support-revert_flickwerk branch from daa306b to fc51732 Compare December 18, 2024 10:45
@github-actions github-actions bot removed the changelog:solidus_core Changes to the solidus_core gem label Dec 18, 2024
@tvdeyen tvdeyen enabled auto-merge December 18, 2024 10:46
@tvdeyen tvdeyen merged commit 811f14d into solidusio:main Dec 18, 2024
12 of 14 checks passed
@tvdeyen tvdeyen deleted the solidus_support-revert_flickwerk branch December 18, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_admin changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants