-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use at least solidus_support 0.12.0 #6037
Use at least solidus_support 0.12.0 #6037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this, it was really stumping me. Much appreciated 💛 Looks like the error has shifted a bit from its original message I was seeing but the solidus_installer
step still fails. Definitely working a bit better now though as some specs can actually run!
0ebd0ac
to
41a0b8b
Compare
41a0b8b
to
b49593b
Compare
Yeah, it's a bit tricky because the rails app template for the solidus installer uses the github main branch of solidus_starter_frontend. I added solidusio/solidus_starter_frontend#394 to fix that |
core/lib/generators/solidus/install/app_templates/frontend/starter.rb
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6037 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 790 790
Lines 18224 18224
=======================================
Hits 16324 16324
Misses 1900 1900 ☔ View full report in Codecov by Sentry. |
Fix pulled from tvdeyen's pr: solidusio#6037 I just want to see if it fixes my PR.
solidus_support 0.11.0 introduced flickwerk for patch loading. Somehow this messes with the zeitwerk autoloader and things acting weird (inflections broken, wrong constant module nesting, etc.) 0.12.0 reverted flickwerk.
Sometimes the modal that contains the field is not present yet. Let's use capybara's waiting capabilities before filling the field.
daa306b
to
fc51732
Compare
solidus_support 0.11.0 introduced flickwerk for patch
loading. Somehow this messes with the zeitwerk autoloader
and things acting weird (inflections broken, wrong constant
module nesting, etc.)
0.12.0 reverted flickwerk.