Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add Prettier config #6043

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[Admin] Add Prettier config #6043

merged 2 commits into from
Dec 20, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 19, 2024

Summary

Add a prettier config and adjust all admin JS files to the syntax rules.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

This allows to run prettier in your editor
Adjust the syntax of all admin js files to
prettier config.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvdeyen!

Unrelated: do we need the chore(admin): part in the commit message? I don't think we ever used this format before, and we have the changelog tag already indicating where the change has effect. Despite I don't particularly like this format, I don't have strong preferences and I'm ok with you committing this way if you prefer. ❤️

@tvdeyen tvdeyen merged commit 9234436 into solidusio:main Dec 20, 2024
14 checks passed
@tvdeyen tvdeyen deleted the prettier-config branch December 20, 2024 10:36
@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 20, 2024

I don't mind changing it, but auto merge was already enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants