[Admin] Open edit and new forms in dialog with turbo frame #6046
+250
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
2 times, most recently
from
22f5345 to
5e2c4da
Compare
3.21.0 introduced a bug with testing view components.
3 tasks
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
from
5e2c4da to
909607d
Compare
tvdeyen
changed the title
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
from
909607d to
184c645
Compare
If a table has no rowUrl defined we currently redirect to root path. Which is not preferable. We should do nothing instead.
We do not want to render the whole layout if the request is a turbo frame request. We just want to render the component's html.
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
from
354c7c2 to
a1e9278
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6046 +/- ##
==========================================
+ Coverage 87.82% 89.59% +1.76%
==========================================
Files 477 791 +314
Lines 11670 18254 +6584
==========================================
+ Hits 10249 16354 +6105
- Misses 1421 1900 +479 ☔ View full report in Codecov by Sentry. |
This is actual links to open the new and edit forms in the modal dialog remotely.
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
from
a1e9278 to
162d93c
Compare
tvdeyen
force-pushed
the
open-modal-content-remotely
branch
from
162d93c to
ca8ae78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6048
Summary
Opens new and edit forms of Admin resources in dialogs with Turbo Frames.
Removing the need of rendering the index table again on the form components.
Also handles the layout toggle for all turbo frame requests.
Includes the ground work from #6045
Closes #5944
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: