-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update licenses #6084
base: main
Are you sure you want to change the base?
Update licenses #6084
Conversation
Added Inter License Corrected Reference to other License file Update LICENSE.md formating Update License.md with reference to other licenses Added License for Remixicon
a7f7a88
to
f9209f1
Compare
@tvdeyen could you also look here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6084 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 813 813
Lines 17906 17906
=======================================
Hits 15987 15987
Misses 1919 1919 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Co-authored-by: Thomas von Deyen <[email protected]>
Several licenses diverge, for now I have mentioned them in the additional license file, individual checks should be made to evaluate if the license files can be merged into the parent license of the repository.
@tvdeyen I think I found all boilerplate licenses, please merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fthobe I found that we have individual LICENSE
files in most of the gems
- admin
- api
backend- core
legacy_promotionspromotions- sample
The LICENSE
file in the root folder is not part of the bundled solidus gem.
How to we handle this? My guess is that we need to update all individual licenses, because people are able to install just solidus_api
and the license should still be available in the shipped gem package, right? Not sure how other mono-repos handles this.
@fthobe please use rebase to update this branch with main (and not merge), thanks 🙏🏻 |
So there are various approaches to that:
Keep in mind that a referral to a valid license is as good as a valid license in most jurisdictions (actually Germany is a notable exception where there are for years final decisions pending if a license is valid if it can not be reviewed during the moment of purchase / acquisition of the software). |
Summary
Related to previous conversations in PR #5948.
Copyright lists alphabetically the major contributors, points for generic contributions to the git commit list.
Some open issues:
Fixes #5947
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: