Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licenses #6084

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Jan 20, 2025

Summary

Related to previous conversations in PR #5948.
Copyright lists alphabetically the major contributors, points for generic contributions to the git commit list.

Some open issues:

  • is the logo currently protected?
  • is the brand "Solidus" currently protected?
  • I also added inter

Fixes #5947

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 20, 2025
Added Inter License
Corrected Reference to other License file
Update LICENSE.md formating
Update License.md with reference to other licenses
Added License for Remixicon
@fthobe fthobe force-pushed the Fix-License-Issues branch from a7f7a88 to f9209f1 Compare January 22, 2025 18:07
@fthobe
Copy link
Contributor Author

fthobe commented Jan 22, 2025

@tvdeyen could you also look here

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.28%. Comparing base (b1b8567) to head (fa21e97).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6084   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files         813      813           
  Lines       17906    17906           
=======================================
  Hits        15987    15987           
  Misses       1919     1919           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthobe fthobe marked this pull request as ready for review January 22, 2025 18:22
@fthobe fthobe requested a review from a team as a code owner January 22, 2025 18:22
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

LICENSE.md Outdated Show resolved Hide resolved
fthobe and others added 3 commits January 29, 2025 08:43
Co-authored-by: Thomas von Deyen <[email protected]>
Several licenses diverge, for now I have mentioned them in the additional license file, individual checks should be made to evaluate if the license files can be merged into the parent license of the repository.
@fthobe
Copy link
Contributor Author

fthobe commented Jan 29, 2025

@tvdeyen I think I found all boilerplate licenses, please merge this.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fthobe I found that we have individual LICENSE files in most of the gems

  • admin
  • api
  • backend
  • core
  • legacy_promotions
  • promotions
  • sample

The LICENSE file in the root folder is not part of the bundled solidus gem.

How to we handle this? My guess is that we need to update all individual licenses, because people are able to install just solidus_api and the license should still be available in the shipped gem package, right? Not sure how other mono-repos handles this.

@tvdeyen
Copy link
Member

tvdeyen commented Jan 31, 2025

@fthobe please use rebase to update this branch with main (and not merge), thanks 🙏🏻

@tvdeyen tvdeyen changed the title Fix license issues Update licenses Jan 31, 2025
@fthobe
Copy link
Contributor Author

fthobe commented Jan 31, 2025

@fthobe I found that we have individual LICENSE files in most of the gems

  • admin

  • api

  • backend

  • core

  • legacy_promotions

  • promotions

  • sample

The LICENSE file in the root folder is not part of the bundled solidus gem.

How to we handle this? My guess is that we need to update all individual licenses, because people are able to install just solidus_api and the license should still be available in the shipped gem package, right? Not sure how other mono-repos handles this.

So there are various approaches to that:

  • we should as first step harmonise what can be harmonised: where licenses are identical we should refer to the parent license
  • additional licenses in subfolders are perfectly fine but we should add at least a reference from parent folder more for clarity than hard legal requirements

Keep in mind that a referral to a valid license is as good as a valid license in most jurisdictions (actually Germany is a notable exception where there are for years final decisions pending if a license is valid if it can not be reviewed during the moment of purchase / acquisition of the software).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Issue Remixicon
2 participants