[Admin][UI] Allow select to include blank option #6279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6279 +/- ##
==========================================
- Coverage 88.95% 88.95% -0.01%
==========================================
Files 860 860
Lines 18423 18419 -4
==========================================
- Hits 16388 16384 -4
Misses 2035 2035 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaimann
force-pushed
the
admin-ui-select-include-blank
branch
2 times, most recently
from
ddaabfb to
287cbdc
Compare
`choices` param is now forced to be an Array, as it will be easier to include blank option in an array. Previously it implicitly allowed it to be html safe string containing markup for options as well, but using arrays is a lot easier.
Following the change in UI select component, forcing `choices` to be an array, needed to change few store credit components passing their options as a string. Also removes blank option for currency selector, since there is a default selected value, and currency cannot be blank, so there is no reason to allow selecting a blank option there.
chaimann
force-pushed
the
admin-ui-select-include-blank
branch
from
287cbdc to
9e32dad
Compare
tvdeyen
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Split from #6228
Summary
Updates UI select component to allow including blank option. Drops support for passing options as html safe string, forcing
choicesto be an Array, and updates few places where options were still passed as strings.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: