Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch PaypalOrder Discount Breakdown #192

Closed
wants to merge 1 commit into from
Closed

Patch PaypalOrder Discount Breakdown #192

wants to merge 1 commit into from

Conversation

jakemumu
Copy link

@jakemumu jakemumu commented Mar 13, 2023

Summary

This patches an issue in the PayPal order breakdown causing PayPal to reject creating the modal window.

More details here: #191

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@kennyadsl
Copy link
Member

Thanks! To avoid future regressions, do you think it would be possible to add a spec? If you need help with that, just let us know and we'll provide some guidance. 🙏

@jakemumu
Copy link
Author

Thanks! To avoid future regressions, do you think it would be possible to add a spec?

Definitely, let me try to figure it out I think I got it

@jakemumu jakemumu closed this by deleting the head repository Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants