Skip to content

WIP fix flakey feature test #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Draft

WIP fix flakey feature test #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions templates/spec/support/solidus_starter_frontend/database_cleaner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@
DatabaseCleaner.clean_with :truncation
end

# Around each spec check if it is a Javascript test and switch between using
# database transactions or not where necessary.
config.around(:each) do |example|
DatabaseCleaner.strategy = RSpec.current_example.metadata[:js] ? :truncation : :transaction
DatabaseCleaner.cleaning { example.run }
# Set database cleaner strategy before test data is created
config.before(:each) do |example|
DatabaseCleaner.strategy = example.metadata[:js] ? :truncation : :transaction
DatabaseCleaner.start
end

config.after(:each) do
DatabaseCleaner.clean
end
end
4 changes: 4 additions & 0 deletions templates/spec/system/coupon_code_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ def create_basic_coupon_promotion(code)

# To shipping method screen
click_button "Save and Continue"
expect(page).to have_content("Shipping Method")
# To payment screen
click_button "Save and Continue"
expect(page).to have_content("Payment Information")
end

it "informs about an invalid coupon code" do
Expand Down Expand Up @@ -102,8 +104,10 @@ def create_basic_coupon_promotion(code)
# To shipping method screen, address is auto-populated
# with user's saved addresses
click_button "Save and Continue"
expect(page).to have_content("Shipping Method")
# To payment screen
click_button "Save and Continue"
expect(page).to have_content("Payment Information")
end

it "shows wallet payments on coupon code errors" do
Expand Down